Skip to content

Commit 44cba9a

Browse files
author
Mykhailo Babych
committed
chore: Upgrade S3 module
1 parent 304e233 commit 44cba9a

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ In the above diagram, you can see the components and their relations (PostgreSQL
3636
|------|--------|---------|
3737
| <a name="module_gitlab_policy"></a> [gitlab\_policy](#module\_gitlab\_policy) | terraform-aws-modules/iam/aws//modules/iam-policy | v6.4.0 |
3838
| <a name="module_gitlab_role"></a> [gitlab\_role](#module\_gitlab\_role) | terraform-aws-modules/iam/aws//modules/iam-role | v6.4.0 |
39-
| <a name="module_s3_bucket"></a> [s3\_bucket](#module\_s3\_bucket) | terraform-aws-modules/s3-bucket/aws | 4.1.0 |
39+
| <a name="module_s3_bucket"></a> [s3\_bucket](#module\_s3\_bucket) | terraform-aws-modules/s3-bucket/aws | 5.10.0 |
4040

4141
## Resources
4242

main.tf

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -223,10 +223,9 @@ data "aws_iam_policy_document" "s3_bucket_policy" {
223223
module "s3_bucket" {
224224
for_each = local.buckets_list
225225
source = "terraform-aws-modules/s3-bucket/aws"
226-
version = "4.1.0"
226+
version = "5.10.0"
227227

228228
bucket = each.value
229-
acl = null
230229
force_destroy = false
231230

232231
versioning = {
@@ -298,7 +297,7 @@ module "gitlab_role" {
298297

299298
oidc_provider_urls = [data.aws_eks_cluster.eks.identity[0].oidc[0].issuer]
300299
oidc_wildcard_subjects = ["system:serviceaccount:${local.release_namespace}:gitlab*"]
301-
oidc_audiences = ["[sts.amazonaws.com](http://sts.amazonaws.com)"]
300+
oidc_audiences = ["sts.amazonaws.com"]
302301

303302
policies = {
304303
gitlab-role-policy = module.gitlab_policy.arn

0 commit comments

Comments
 (0)