resolves Phaiax/Key-n-Stroke#80#90
Open
ckelwin wants to merge 3 commits into
Open
Conversation
Author
|
Found a ⇧ (Shift symbol) in |
kmpm
reviewed
Aug 10, 2022
Contributor
kmpm
left a comment
There was a problem hiding this comment.
I like this and it basically looks good to me but with some comments.
5cc31f3 to
ea63ffe
Compare
Co-authored-by: Peter Magnusson <git@kmpm.se>
Author
|
@kmpm Refactored based on your input. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Phaiax Implemented for Shift, CapsLock, Return, Backspace, Tab, PageUp, PageDown, End and Home keys. Added checkbox "Text instead of symbols" in settings to toggle between showing text or symbols. Default is unchecked to retain default behaviour.
Unchecked:

Checked:
