Skip to content

resolves Phaiax/Key-n-Stroke#80#90

Open
ckelwin wants to merge 3 commits into
Phaiax:masterfrom
ckelwin:80-alternate-to-symbols
Open

resolves Phaiax/Key-n-Stroke#80#90
ckelwin wants to merge 3 commits into
Phaiax:masterfrom
ckelwin:80-alternate-to-symbols

Conversation

@ckelwin
Copy link
Copy Markdown

@ckelwin ckelwin commented Jul 31, 2022

@Phaiax Implemented for Shift, CapsLock, Return, Backspace, Tab, PageUp, PageDown, End and Home keys. Added checkbox "Text instead of symbols" in settings to toggle between showing text or symbols. Default is unchecked to retain default behaviour.

image

Unchecked:
image

Checked:
image

@ckelwin
Copy link
Copy Markdown
Author

ckelwin commented Jul 31, 2022

Found a ⇧ (Shift symbol) in Resources\mouse.svg that is not addressed in this PR.

Copy link
Copy Markdown
Contributor

@kmpm kmpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this and it basically looks good to me but with some comments.

Comment thread KeyNStroke/SpecialkeysParser.cs Outdated
Comment thread KeyNStroke/SpecialkeysParser.cs Outdated
Comment thread KeyNStroke/App.xaml.cs Outdated
Implemented for Shift, CapsLock, Return, Backspace, Tab, PageUp, PageDown, End and Home keys. Added checkbox "Text instead of symbols" in settings to toggle between showing text or symbols. Default is unchecked to retain default behavior.
@ckelwin ckelwin force-pushed the 80-alternate-to-symbols branch from 5cc31f3 to ea63ffe Compare August 12, 2022 17:44
ckelwin and others added 2 commits August 19, 2022 17:38
Co-authored-by: Peter Magnusson <git@kmpm.se>
Refactor based on review comments. Passing bool instead of SettingsStore.
@ckelwin
Copy link
Copy Markdown
Author

ckelwin commented Aug 26, 2022

@kmpm Refactored based on your input.

@Phaiax
Copy link
Copy Markdown
Owner

Phaiax commented Aug 26, 2022

Thanks a lot @ckelwin and @kmpm, I'll look at this and the other issues and PRs in the next days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants