fix 354

Author: Alfagun74

CHANGELOG.md

@@ -7,11 +7,11 @@
 - [#364](https://github.com/Phalcode/gamevault-backend/issues/364) Parental Control
   - Games without any age rating set, are now shown in the game list for all users. -> **If you use parental control, apply an age rating to your games, if you don't want to show them to everyone.**
   - Admins can now see all games, regardless of their age rating.
-
 - [#362](https://github.com/Phalcode/gamevault-backend/issues/362) Gracefully handle chown/chmod failures on NFS-mounted volumes
 - [#363](https://github.com/Phalcode/gamevault-backend/issues/363) IGDB ID Search Results now always return as first result.
 - [#365](https://github.com/Phalcode/gamevault-backend/issues/365) Fixed Early Access Games not showing up in the Early Access List, depending on the filename. -> **Recache games, that still show issues**
 - Redirected early access and release date sorting & filtering to the respective metadata fields.
+- [#354](https://github.com/Phalcode/gamevault-backend/issues/354) Moved setting the default install parameters from IGDB Provider to fallback in metadata merge process and only set them if its a Windows Setup Game.
 
 ### Thanks
 

src/modules/metadata/metadata.service.ts

@@ -15,6 +15,7 @@ import configuration from "../../configuration";
 import { logGamevaultGame, logMetadataProvider } from "../../logging";
 import { GamesService } from "../games/games.service";
 import { GamevaultGame } from "../games/gamevault-game.entity";
+import { GameType } from "../games/models/game-type.enum";
 import { GameMetadata } from "./games/game.metadata.entity";
 import { GameMetadataService } from "./games/game.metadata.service";
 import { MinimalGameMetadataDto } from "./games/minimal-game.metadata.dto";
@@ -350,8 +351,12 @@ export class MetadataService {
 
     let mergedMetadata = new GameMetadata();
 
-    // Fallback release date from file
+    // Set fallback data
     mergedMetadata.release_date = game.release_date;
+    if (game.type === GameType.WINDOWS_SETUP) {
+      mergedMetadata.installer_parameters =
+        '/D="%INSTALLDIR%" /S /DIR="%INSTALLDIR%" /SILENT /COMPONENTS=text';
+    }
 
     // Create New Effective Metadata by applying the priorotized metadata one by one
     for (const metadata of providerMetadata) {

src/modules/metadata/providers/igdb/igdb.metadata-provider.service.ts

@@ -237,8 +237,6 @@ export class IgdbMetadataProviderService extends MetadataProvider {
         "t_thumb",
         "t_1080p_2x",
       ),
-      installer_parameters:
-        '/D="%INSTALLDIR%" /S /DIR="%INSTALLDIR%" /SILENT /COMPONENTS=text',
     } as GameMetadata;
   }