fix bug

Author: Alfagun74

src/modules/games/files.service.spec.ts

@@ -466,15 +466,48 @@ describe("FilesService", () => {
   });
 
   describe("upsertReleaseRecord", () => {
-    it("should upsert game versions atomically via query builder", async () => {
-      const execute = jest.fn().mockResolvedValue(undefined);
-      const orUpdate = jest.fn().mockReturnValue({ execute });
-      const values = jest.fn().mockReturnValue({ orUpdate });
-      const into = jest.fn().mockReturnValue({ values });
-      const insert = jest.fn().mockReturnValue({ into });
-      const qb = { insert };
+    it("should create a new release row when none exists", async () => {
+      gameVersionRepository.findOne.mockResolvedValueOnce(null);
+      gameVersionRepository.save.mockResolvedValueOnce(undefined);
 
-      gameVersionRepository.createQueryBuilder.mockReturnValue(qb as any);
+      await (service as any).upsertReleaseRecord(9, {
+        file_path: "/tmp/test-files/Game (v2).zip",
+        version: "v2",
+        size: 2000n,
+        release_date: new Date("2025-01-01T00:00:00.000Z"),
+        early_access: true,
+        type: "WINDOWS_PORTABLE",
+      });
+
+      expect(gameVersionRepository.findOne).toHaveBeenCalledWith(
+        expect.objectContaining({
+          where: {
+            game: { id: 9 },
+            file_path: "/tmp/test-files/Game (v2).zip",
+          },
+          withDeleted: true,
+        }),
+      );
+      expect(gameVersionRepository.save).toHaveBeenCalledWith(
+        expect.objectContaining({
+          id: undefined,
+          game: { id: 9 },
+          file_path: "/tmp/test-files/Game (v2).zip",
+          version: "v2",
+          size: 2000n,
+          early_access: true,
+          type: "WINDOWS_PORTABLE",
+          deleted_at: null,
+        }),
+      );
+    });
+
+    it("should update an existing release row by reusing its id", async () => {
+      gameVersionRepository.findOne.mockResolvedValueOnce({
+        id: 42,
+        file_path: "/tmp/test-files/Game (v2).zip",
+      });
+      gameVersionRepository.save.mockResolvedValueOnce(undefined);
 
       await (service as any).upsertReleaseRecord(9, {
         file_path: "/tmp/test-files/Game (v2).zip",
@@ -485,12 +518,14 @@ describe("FilesService", () => {
         type: "WINDOWS_PORTABLE",
       });
 
-      expect(gameVersionRepository.createQueryBuilder).toHaveBeenCalled();
-      expect(orUpdate).toHaveBeenCalledWith(
-        expect.arrayContaining(["deleted_at", "updated_at"]),
-        ["game_id", "file_path"],
+      expect(gameVersionRepository.save).toHaveBeenCalledWith(
+        expect.objectContaining({
+          id: 42,
+          game: { id: 9 },
+          file_path: "/tmp/test-files/Game (v2).zip",
+          deleted_at: null,
+        }),
       );
-      expect(execute).toHaveBeenCalled();
     });
   });
 

src/modules/games/files.service.ts

@@ -416,36 +416,28 @@ export class FilesService implements OnApplicationBootstrap {
   ): Promise<void> {
     const now = new Date();
 
-    await this.gameVersionRepository
-      .createQueryBuilder()
-      .insert()
-      .into(GameVersion)
-      .values({
-        game: { id: gameId } as GamevaultGame,
+    const existingVersion = await this.gameVersionRepository.findOne({
+      where: {
+        game: { id: gameId },
         file_path: indexedGame.file_path,
-        version: indexedGame.version,
-        size: indexedGame.size,
-        release_date: indexedGame.release_date,
-        early_access: indexedGame.early_access,
-        type: indexedGame.type,
-        indexed_at: now,
-        deleted_at: null,
-        updated_at: now,
-      })
-      .orUpdate(
-        [
-          "version",
-          "size",
-          "release_date",
-          "early_access",
-          "type",
-          "indexed_at",
-          "deleted_at",
-          "updated_at",
-        ],
-        ["game_id", "file_path"],
-      )
-      .execute();
+      },
+      withDeleted: true,
+    });
+
+    const versionPatch = Object.assign(new GameVersion(), {
+      id: existingVersion?.id,
+      game: { id: gameId } as GamevaultGame,
+      file_path: indexedGame.file_path,
+      version: indexedGame.version,
+      size: indexedGame.size,
+      release_date: indexedGame.release_date,
+      early_access: indexedGame.early_access,
+      type: indexedGame.type,
+      indexed_at: now,
+      deleted_at: null,
+    });
+
+    await this.gameVersionRepository.save(versionPatch);
   }
 
   /** Returns all versions from normalized storage, falling back to legacy columns. */