Refactor: Extract validation helper, remove console spies, share widget names constant

Co-authored-by: PhantomDave <34485699+PhantomDave@users.noreply.github.com>

Author: Copilot

PhantomDave.BankTracking.Api/Types/Mutations/DashboardWidgetMutations.cs

@@ -38,35 +38,8 @@ public async Task<DashboardWidgetType> AddWidget(
                     .Build());
         }
 
-        string? title = null;
-        if (input.Title is not null)
-        {
-            var trimmedTitle = input.Title.Trim();
-            if (string.IsNullOrEmpty(trimmedTitle))
-            {
-                throw new GraphQLException(
-                    ErrorBuilder.New()
-                        .SetMessage("Widget title cannot be empty or whitespace.")
-                        .SetCode("BAD_USER_INPUT")
-                        .Build());
-            }
-            title = trimmedTitle;
-        }
-
-        string? subtitle = null;
-        if (input.Subtitle is not null)
-        {
-            var trimmedSubtitle = input.Subtitle.Trim();
-            if (string.IsNullOrEmpty(trimmedSubtitle))
-            {
-                throw new GraphQLException(
-                    ErrorBuilder.New()
-                        .SetMessage("Widget subtitle cannot be empty or whitespace.")
-                        .SetCode("BAD_USER_INPUT")
-                        .Build());
-            }
-            subtitle = trimmedSubtitle;
-        }
+        var title = ValidateAndTrimString(input.Title, "title");
+        var subtitle = ValidateAndTrimString(input.Subtitle, "subtitle");
 
         var widget = new DashboardWidget
         {
@@ -160,30 +133,12 @@ public async Task<DashboardWidgetType> UpdateWidget(
 
         if (input.Title is not null)
         {
-            var trimmedTitle = input.Title.Trim();
-            if (string.IsNullOrEmpty(trimmedTitle))
-            {
-                throw new GraphQLException(
-                    ErrorBuilder.New()
-                        .SetMessage("Widget title cannot be empty or whitespace.")
-                        .SetCode("BAD_USER_INPUT")
-                        .Build());
-            }
-            widget.Title = trimmedTitle;
+            widget.Title = ValidateAndTrimString(input.Title, "title");
         }
 
         if (input.Subtitle is not null)
         {
-            var trimmedSubtitle = input.Subtitle.Trim();
-            if (string.IsNullOrEmpty(trimmedSubtitle))
-            {
-                throw new GraphQLException(
-                    ErrorBuilder.New()
-                        .SetMessage("Widget subtitle cannot be empty or whitespace.")
-                        .SetCode("BAD_USER_INPUT")
-                        .Build());
-            }
-            widget.Subtitle = trimmedSubtitle;
+            widget.Subtitle = ValidateAndTrimString(input.Subtitle, "subtitle");
         }
 
         if (input.Config is not null)
@@ -230,4 +185,20 @@ public async Task<bool> RemoveWidget(
 
         return true;
     }
+
+    private static string? ValidateAndTrimString(string? value, string fieldName)
+    {
+        if (value is null) return null;
+
+        var trimmed = value.Trim();
+        if (string.IsNullOrEmpty(trimmed))
+        {
+            throw new GraphQLException(
+                ErrorBuilder.New()
+                    .SetMessage($"Widget {fieldName} cannot be empty or whitespace.")
+                    .SetCode("BAD_USER_INPUT")
+                    .Build());
+        }
+        return trimmed;
+    }
 }

frontend/src/app/components/dashboards/dashboard-component/dashboard-component.component.spec.ts

@@ -60,7 +60,6 @@ describe('DashboardComponent', () => {
     });
 
     it('should show error snackbar if widget creation fails', () => {
-      spyOn(console, 'error'); // Suppress console output in tests
       const invalidWidgetType = 'INVALID_TYPE' as WidgetType;
 
       component.onWidgetSelected(invalidWidgetType);
@@ -69,7 +68,6 @@ describe('DashboardComponent', () => {
     });
 
     it('should not add widget to list if creation fails', () => {
-      spyOn(console, 'error'); // Suppress console output in tests
       const invalidWidgetType = 'INVALID_TYPE' as WidgetType;
       const initialWidgetCount = component.widgets().length;
 

frontend/src/app/components/dashboards/dashboard-component/dashboard-component.component.ts

@@ -19,6 +19,7 @@ import { WidgetType } from '../../../../generated/graphql';
 import { Widget } from '../../../models/dashboards/gridster-item';
 import { WidgetFactory } from '../widgets/widget-factory';
 import { SnackbarService } from '../../../shared/services/snackbar.service';
+import { WIDGET_DISPLAY_NAMES } from '../../../constants/widget-names';
 
 @Component({
   standalone: true,
@@ -154,11 +155,7 @@ export class DashboardComponent implements OnInit {
       const widget = WidgetFactory.createWidget(widgetType);
       this.widgets.set([...this.widgets(), widget]);
 
-      const widgetNames: Record<WidgetType, string> = {
-        [WidgetType.NET_GRAPH]: 'Net Graph',
-        [WidgetType.CURRENT_BALANCE]: 'Remaining Budget',
-      };
-      const widgetName = widgetNames[widgetType] ?? String(widgetType);
+      const widgetName = WIDGET_DISPLAY_NAMES[widgetType] ?? String(widgetType);
       this.snackbarService.success(`Added ${widgetName} widget to dashboard.`);
     } catch (error) {
       this.snackbarService.error('Failed to add widget to dashboard.');

frontend/src/app/components/dashboards/dashboard-drawer-component/dashboard-drawer-component.component.ts

@@ -4,6 +4,7 @@ import { MatIconButton } from '@angular/material/button';
 import { MatIcon } from '@angular/material/icon';
 import { FlexComponent } from '../../ui-library/flex-component/flex-component';
 import { WidgetType } from '../../../../generated/graphql';
+import { WIDGET_DISPLAY_NAMES } from '../../../constants/widget-names';
 
 @Component({
   selector: 'app-dashboard-drawer-component',
@@ -17,14 +18,9 @@ export class DashboardDrawerComponent {
   closed = output<void>();
   widgetSelected = output<WidgetType>();
 
-  private static readonly WIDGET_DISPLAY_NAMES: Record<WidgetType, string> = {
-    [WidgetType.NET_GRAPH]: 'Net Graph',
-    [WidgetType.CURRENT_BALANCE]: 'Remaining Budget',
-  };
-
   readonly availableWidgets = Object.values(WidgetType).map((type) => ({
     type,
-    name: DashboardDrawerComponent.WIDGET_DISPLAY_NAMES[type] ?? String(type),
+    name: WIDGET_DISPLAY_NAMES[type] ?? String(type),
   }));
 
   addWidgetToDashboard(widget: { type: WidgetType; name: string }) {

frontend/src/app/constants/widget-names.ts

@@ -0,0 +1,6 @@
+import { WidgetType } from '../../generated/graphql';
+
+export const WIDGET_DISPLAY_NAMES: Record<WidgetType, string> = {
+  [WidgetType.NET_GRAPH]: 'Net Graph',
+  [WidgetType.CURRENT_BALANCE]: 'Remaining Budget',
+};