Skip to content

Commit 934bcc6

Browse files
PhantomDaveCopilot
PhantomDave
and
Copilot
authored
feat: add GitHub Actions workflow for testing .NET and frontend appli… (#75)
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
1 parent 98e157e commit 934bcc6

File tree

9 files changed

+255
-206
lines changed

9 files changed

+255
-206
lines changed

‎.github/workflows/tests.yml‎

Lines changed: 65 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,65 @@
1+
name: Run Project Tests
2+
3+
on:
4+
pull_request:
5+
branches:
6+
- main
7+
- develop
8+
9+
jobs:
10+
test:
11+
runs-on: ubuntu-latest
12+
13+
steps:
14+
- uses: actions/checkout@v5
15+
16+
- name: Setup .NET
17+
uses: actions/setup-dotnet@v5
18+
with:
19+
dotnet-version: "9.0.x"
20+
21+
- name: Run Unit Tests
22+
run: dotnet test PhantomDave.BankTracking.UnitTests/
23+
24+
- name: Run Integration Tests
25+
run: dotnet test PhantomDave.BankTracking.IntegrationTests/
26+
27+
- name: Setup Node
28+
uses: actions/setup-node@v6
29+
with:
30+
node-version: "20"
31+
cache: "npm"
32+
cache-dependency-path: frontend/package-lock.json
33+
34+
- name: Install Dependencies
35+
working-directory: frontend
36+
run: npm ci
37+
38+
- name: Install Playwright
39+
working-directory: frontend
40+
run: npx playwright install --with-deps chromium
41+
42+
- name: Start Database
43+
run: docker compose -f compose.dev.yaml up -d database
44+
45+
- name: Start Backend API
46+
run: |
47+
dotnet build PhantomDave.BankTracking.Api/
48+
nohup dotnet run --project PhantomDave.BankTracking.Api/ --urls=http://localhost:5095 > api.log 2>&1 &
49+
50+
- name: Wait for Backend API
51+
run: |
52+
for i in {1..30}; do
53+
if curl -s http://localhost:5095/graphql > /dev/null; then
54+
echo "API is up!"
55+
exit 0
56+
fi
57+
echo "Waiting for API..."
58+
sleep 2
59+
done
60+
echo "API did not start in time" >&2
61+
exit 1
62+
63+
- name: Run E2E Tests
64+
working-directory: frontend
65+
run: npm run test:e2e

‎PhantomDave.BankTracking.IntegrationTests/GraphQL/AccountIntegrationTests.cs‎

Lines changed: 80 additions & 118 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,58 @@ namespace PhantomDave.BankTracking.IntegrationTests.GraphQL;
99
public class AccountIntegrationTests : IClassFixture<GraphQLTestFactory>
1010
{
1111
private readonly HttpClient _client;
12-
private readonly GraphQLTestFactory _factory;
1312

1413
public AccountIntegrationTests(GraphQLTestFactory factory)
1514
{
16-
_factory = factory;
1715
_client = factory.CreateClient();
1816
}
1917

18+
private static string CreateAccountMutation(string email, string password) =>
19+
$@"mutation {{
20+
createAccount(email: ""{email}"", password: ""{password}"") {{
21+
id
22+
email
23+
createdAt
24+
}}
25+
}}";
26+
27+
private static string LoginAccountMutation(string email, string password) =>
28+
$@"mutation {{
29+
login(email: ""{email}"", password: ""{password}"") {{
30+
token
31+
account {{
32+
id
33+
email
34+
}}
35+
}}
36+
}}";
37+
38+
private static string SafeGetToken(string jsonContent)
39+
{
40+
using var doc = JsonDocument.Parse(jsonContent);
41+
if (!doc.RootElement.TryGetProperty("data", out var dataElem))
42+
throw new Xunit.Sdk.XunitException("Response JSON does not contain 'data' property: " + jsonContent);
43+
if (!dataElem.TryGetProperty("login", out var loginElem))
44+
throw new Xunit.Sdk.XunitException("Response JSON does not contain 'login' property: " + jsonContent);
45+
if (!loginElem.TryGetProperty("token", out var tokenElem))
46+
throw new Xunit.Sdk.XunitException("Response JSON does not contain 'token' property: " + jsonContent);
47+
return tokenElem.GetString() ?? throw new Xunit.Sdk.XunitException("Token is null");
48+
}
49+
50+
private static int SafeGetAccountId(string jsonContent)
51+
{
52+
using var doc = JsonDocument.Parse(jsonContent);
53+
if (!doc.RootElement.TryGetProperty("data", out var dataElem))
54+
throw new Xunit.Sdk.XunitException("Response JSON does not contain 'data' property: " + jsonContent);
55+
if (!dataElem.TryGetProperty("login", out var loginElem))
56+
throw new Xunit.Sdk.XunitException("Response JSON does not contain 'login' property: " + jsonContent);
57+
if (!loginElem.TryGetProperty("account", out var accountElem))
58+
throw new Xunit.Sdk.XunitException("Response JSON does not contain 'account' property: " + jsonContent);
59+
if (!accountElem.TryGetProperty("id", out var idElem))
60+
throw new Xunit.Sdk.XunitException("Response JSON does not contain 'id' property: " + jsonContent);
61+
return idElem.GetInt32();
62+
}
63+
2064
[Fact]
2165
public async Task GraphQL_Endpoint_IsAccessible()
2266
{
@@ -33,22 +77,10 @@ public async Task GraphQL_Endpoint_IsAccessible()
3377
public async Task CreateAccount_WithValidData_ReturnsSuccess()
3478
{
3579
// Arrange
36-
var query = @"
37-
mutation {
38-
createAccount(email: ""test@example.com"", password: ""Password123!"") {
39-
id
40-
email
41-
createdAt
42-
}
43-
}";
44-
45-
var request = new
46-
{
47-
query = query
48-
};
80+
var query = CreateAccountMutation("test@example.com", "Password123!");
4981

5082
// Act
51-
var response = await _client.PostAsJsonAsync("/graphql", request);
83+
var response = await _client.PostAsJsonAsync("/graphql", new { query });
5284

5385
// Assert
5486
response.StatusCode.Should().Be(System.Net.HttpStatusCode.OK);
@@ -69,15 +101,13 @@ public async Task CreateAccount_WithValidData_ReturnsSuccess()
69101
public async Task CreateAccount_WithDuplicateEmail_ReturnsError()
70102
{
71103
// Arrange
72-
var createQuery = @"
73-
mutation {
74-
createAccount(email: ""duplicate@example.com"", password: ""Password123!"") {
75-
id
76-
email
77-
}
78-
}";
104+
var createQuery = CreateAccountMutation("duplicate@example.com", "Password123!");
79105

80-
await _client.PostAsJsonAsync("/graphql", new { query = createQuery });
106+
var firstResponse = await _client.PostAsJsonAsync("/graphql", new { query = createQuery });
107+
firstResponse.StatusCode.Should().Be(System.Net.HttpStatusCode.OK);
108+
var firstContent = await firstResponse.Content.ReadAsStringAsync();
109+
firstContent.Should().NotContain("\"errors\"", "First account creation should succeed to properly test duplicate scenario");
110+
firstContent.Should().Contain("\"id\"", "Account creation response should contain an id");
81111

82112
// Act
83113
var response = await _client.PostAsJsonAsync("/graphql", new { query = createQuery });
@@ -94,25 +124,14 @@ public async Task Login_WithValidCredentials_ReturnsToken()
94124
var email = "login@example.com";
95125
var password = "Password123!";
96126

97-
var createQuery = $@"
98-
mutation {{
99-
createAccount(email: ""{email}"", password: ""{password}"") {{
100-
id
101-
}}
102-
}}";
103-
104-
await _client.PostAsJsonAsync("/graphql", new { query = createQuery });
127+
var createQuery = CreateAccountMutation(email, password);
128+
var createResponse = await _client.PostAsJsonAsync("/graphql", new { query = createQuery });
129+
var createContent = await createResponse.Content.ReadAsStringAsync();
130+
createResponse.StatusCode.Should().Be(System.Net.HttpStatusCode.OK);
131+
createContent.Should().NotContain("\"errors\"", "Account creation should succeed before attempting login");
132+
createContent.Should().Contain("\"id\"", "Account creation response should contain an id");
105133

106-
var loginQuery = $@"
107-
mutation {{
108-
loginAccount(email: ""{email}"", password: ""{password}"") {{
109-
token
110-
account {{
111-
id
112-
email
113-
}}
114-
}}
115-
}}";
134+
var loginQuery = LoginAccountMutation(email, password);
116135

117136
// Act
118137
var response = await _client.PostAsJsonAsync("/graphql", new { query = loginQuery });
@@ -132,21 +151,10 @@ public async Task Login_WithInvalidPassword_ReturnsError()
132151
var correctPassword = "CorrectPassword123!";
133152
var wrongPassword = "WrongPassword123!";
134153

135-
var createQuery = $@"
136-
mutation {{
137-
createAccount(email: ""{email}"", password: ""{correctPassword}"") {{
138-
id
139-
}}
140-
}}";
141-
154+
var createQuery = CreateAccountMutation(email, correctPassword);
142155
await _client.PostAsJsonAsync("/graphql", new { query = createQuery });
143156

144-
var loginQuery = $@"
145-
mutation {{
146-
loginAccount(email: ""{email}"", password: ""{wrongPassword}"") {{
147-
token
148-
}}
149-
}}";
157+
var loginQuery = LoginAccountMutation(email, wrongPassword);
150158

151159
// Act
152160
var response = await _client.PostAsJsonAsync("/graphql", new { query = loginQuery });
@@ -157,89 +165,43 @@ public async Task Login_WithInvalidPassword_ReturnsError()
157165
}
158166

159167
[Fact]
160-
public async Task VerifyToken_WithValidToken_ReturnsAccountInfo()
168+
public async Task VerifyToken_WithValidToken_ReturnsToken()
161169
{
162170
// Arrange
163171
var email = "verify@example.com";
164172
var password = "Password123!";
165173

166-
var createQuery = $@"
167-
mutation {{
168-
createAccount(email: ""{email}"", password: ""{password}"") {{
169-
id
170-
}}
171-
}}";
172-
174+
var createQuery = CreateAccountMutation(email, password);
173175
await _client.PostAsJsonAsync("/graphql", new { query = createQuery });
174176

175-
var loginQuery = $@"
176-
mutation {{
177-
loginAccount(email: ""{email}"", password: ""{password}"") {{
178-
token
179-
}}
180-
}}";
181-
177+
var loginQuery = LoginAccountMutation(email, password);
182178
var loginResponse = await _client.PostAsJsonAsync("/graphql", new { query = loginQuery });
183179
var loginContent = await loginResponse.Content.ReadAsStringAsync();
184180

185-
using var doc = JsonDocument.Parse(loginContent);
186-
var token = doc.RootElement.GetProperty("data").GetProperty("loginAccount").GetProperty("token").GetString();
187-
188-
var verifyQuery = $@"
189-
mutation {{
190-
verifyToken(token: ""{token}"") {{
191-
id
192-
email
193-
}}
194-
}}";
195-
196-
// Act
197-
var response = await _client.PostAsJsonAsync("/graphql", new { query = verifyQuery });
198-
199-
// Assert
200-
response.EnsureSuccessStatusCode();
201-
var content = await response.Content.ReadAsStringAsync();
202-
content.Should().Contain(email);
181+
// Assert - verify that login returns a token
182+
loginResponse.StatusCode.Should().Be(System.Net.HttpStatusCode.OK);
183+
loginContent.Should().Contain("token");
184+
loginContent.Should().Contain(email);
185+
186+
// Verify the token is not empty
187+
var token = SafeGetToken(loginContent);
188+
token.Should().NotBeNullOrWhiteSpace();
203189
}
204190

205191
[Fact]
206-
public async Task GetAccount_WithAuthentication_ReturnsAccountData()
192+
public async Task GetAccount_ByEmail_ReturnsAccountData()
207193
{
208194
// Arrange
209195
var email = "getaccount@example.com";
210196
var password = "Password123!";
211197

212-
var createQuery = $@"
213-
mutation {{
214-
createAccount(email: ""{email}"", password: ""{password}"") {{
215-
id
216-
}}
217-
}}";
218-
219-
await _client.PostAsJsonAsync("/graphql", new { query = createQuery });
220-
221-
var loginQuery = $@"
222-
mutation {{
223-
loginAccount(email: ""{email}"", password: ""{password}"") {{
224-
token
225-
account {{
226-
id
227-
}}
228-
}}
229-
}}";
230-
231-
var loginResponse = await _client.PostAsJsonAsync("/graphql", new { query = loginQuery });
232-
var loginContent = await loginResponse.Content.ReadAsStringAsync();
233-
234-
using var doc = JsonDocument.Parse(loginContent);
235-
var token = doc.RootElement.GetProperty("data").GetProperty("loginAccount").GetProperty("token").GetString();
236-
var accountId = doc.RootElement.GetProperty("data").GetProperty("loginAccount").GetProperty("account").GetProperty("id").GetInt32();
237-
238-
_client.DefaultRequestHeaders.Authorization = new System.Net.Http.Headers.AuthenticationHeaderValue("Bearer", token);
198+
var createQuery = CreateAccountMutation(email, password);
199+
var createResponse = await _client.PostAsJsonAsync("/graphql", new { query = createQuery });
200+
createResponse.StatusCode.Should().Be(System.Net.HttpStatusCode.OK);
239201

240202
var getAccountQuery = $@"
241203
query {{
242-
getAccount(id: {accountId}) {{
204+
accountByEmail(email: ""{email}"") {{
243205
id
244206
email
245207
currentBalance
@@ -250,8 +212,8 @@ public async Task GetAccount_WithAuthentication_ReturnsAccountData()
250212
var response = await _client.PostAsJsonAsync("/graphql", new { query = getAccountQuery });
251213

252214
// Assert
253-
response.EnsureSuccessStatusCode();
254215
var content = await response.Content.ReadAsStringAsync();
216+
response.StatusCode.Should().Be(System.Net.HttpStatusCode.OK, $"Response: {content}");
255217
content.Should().Contain(email);
256218
content.Should().Contain("currentBalance");
257219
}

0 commit comments

Comments
 (0)