Optimize code patterns from recent commits: eliminate duplication, modernize syntax, fix async handling

[Copilot]

Code review of today's commits revealed several suboptimal patterns: duplicate object mapping, redundant null coalescing, outdated C# syntax, missing async/await, and unnecessary computed wrappers.

Changes

Frontend - Eliminate duplication in FinanceRecordService

• Extract repeated object mapping logic into mapToFinanceRecord() helper (~20 lines removed)

// Before: duplicate mapping in two places
if (result) {
  this._selectedFinanceRecord.set({ id: result.data?.createFinanceRecord.id ?? 0, ... });
  this._financeRecords.update(prev => [...prev, { id: result.data?.createFinanceRecord.id ?? 0, ... }]);
}

// After: single source of truth
if (result?.data?.createFinanceRecord) {
  const newRecord = this.mapToFinanceRecord(result.data.createFinanceRecord);
  this._selectedFinanceRecord.set(newRecord);
  this._financeRecords.update(prev => [...prev, newRecord]);
}

Frontend - Remove redundant null coalescing

• Backend already defaults recurrenceFrequency to None, removed ?? RecurrenceFrequency.NONE

Backend - Modernize string slicing

• Replace trimmed.Substring(0, 500) with range operator trimmed[..500]

Frontend - Fix missing await in ConfiguratorComponent

• Add await to createFinanceRecord() call for proper async handling

Frontend - Remove unnecessary computed wrapper

• Direct signal usage instead of computed(() => signal()) pass-through

Build - Support local schema in codegen

• Add USE_LOCAL_SCHEMA env var to build without running GraphQL server

Original prompt

Do a review of the commits made today and see what is done in a wierd/unoptimized way

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[Copilot]

Pull Request Overview

This PR optimizes code patterns from recent commits by eliminating duplication, modernizing syntax, and fixing async handling issues.

• Extracts repeated object mapping logic in FinanceRecordService into a reusable helper method
• Modernizes C# string slicing syntax and removes redundant null coalescing
• Fixes async/await handling in dialog callback and removes unnecessary computed wrapper

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
frontend/src/app/models/finance-record/finance-record-service.ts	Extracts mapToFinanceRecord() helper to eliminate ~20 lines of duplicate mapping logic; removes redundant null coalescing for recurrenceFrequency
frontend/src/app/components/configurator/configurator-component/configurator-component.ts	Adds await to createFinanceRecord() call in dialog callback for proper async handling
frontend/src/app/components/configurator/add-entry/add-entry.ts	Removes unnecessary computed() wrapper by directly using toSignal() for isSubmitDisabled
frontend/codegen.ts	Adds USE_LOCAL_SCHEMA environment variable support for local GraphQL schema building
PhantomDave.BankTracking.Api/Services/FinanceRecordService.cs	Modernizes string slicing from Substring(0, 500) to range operator [..500]

[Copilot]

The date parameter type should be string instead of any since GraphQL returns ISO date strings. This provides better type safety and makes the conversion on line 75 more explicit.

Suggested change

	date: any;
	date: string;

[Copilot]

[nitpick] Consider extracting the inline type definition for the data parameter into a separate type or interface (e.g., CreateFinanceRecordResponse). This would improve reusability if the mapping needs to be used elsewhere and make the type definition more maintainable.