Made the threshold in the renderer use the configuration value. (#33)

* Made the threshold in the renderer use the configuration value.
* Silencing PHPMD for the static call of the YAML parser.

Author: floriankraemer

src/Application.php

@@ -81,7 +81,8 @@ private function registerServices(): void
 
         $this->containerBuilder->register(CognitiveMetricTextRenderer::class, CognitiveMetricTextRenderer::class)
             ->setArguments([
-                new Reference(OutputInterface::class)
+                new Reference(OutputInterface::class),
+                new Reference(ConfigService::class)
             ])
             ->setPublic(true);
 

src/Command/CognitiveMetricsCommand.php

@@ -113,7 +113,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             return $this->reportHandler->handle($metricsCollection, $reportType, $reportFile);
         }
 
-        $this->renderer->render($metricsCollection, $this->metricsFacade->getConfig());
+        $this->renderer->render($metricsCollection);
 
         return Command::SUCCESS;
     }

src/Command/Presentation/CognitiveMetricTextRenderer.php

@@ -8,6 +8,7 @@
 use Phauthentic\CognitiveCodeAnalysis\Business\Cognitive\CognitiveMetricsCollection;
 use Phauthentic\CognitiveCodeAnalysis\CognitiveAnalysisException;
 use Phauthentic\CognitiveCodeAnalysis\Config\CognitiveConfig;
+use Phauthentic\CognitiveCodeAnalysis\Config\ConfigService;
 use Symfony\Component\Console\Helper\Table;
 use Symfony\Component\Console\Output\OutputInterface;
 
@@ -17,7 +18,8 @@
 class CognitiveMetricTextRenderer
 {
     public function __construct(
-        private readonly OutputInterface $output
+        private readonly OutputInterface $output,
+        private readonly ConfigService $configService,
     ) {
     }
 
@@ -30,12 +32,12 @@ private function metricExceedsThreshold(CognitiveMetrics $metric, CognitiveConfi
 
     /**
      * @param CognitiveMetricsCollection $metricsCollection
-     * @param CognitiveConfig $config
      * @throws CognitiveAnalysisException
      */
-    public function render(CognitiveMetricsCollection $metricsCollection, CognitiveConfig $config): void
+    public function render(CognitiveMetricsCollection $metricsCollection): void
     {
         $groupedByClass = $metricsCollection->groupBy('class');
+        $config = $this->configService->getConfig();
 
         foreach ($groupedByClass as $className => $metrics) {
             if (count($metrics) === 0) {
@@ -162,7 +164,7 @@ private function metricsToArray(CognitiveMetrics $metrics): array
             'ifCount' => $metrics->getIfCount(),
             'ifNestingLevel' => $metrics->getIfNestingLevel(),
             'elseCount' => $metrics->getElseCount(),
-            'score' => $metrics->getScore() > 0.5
+            'score' => $metrics->getScore() > $this->configService->getConfig()->scoreThreshold
                 ? '<error>' . $metrics->getScore() . '</error>'
                 : '<info>' . $metrics->getScore() . '</info>',
         ];

src/Config/ConfigService.php

@@ -12,10 +12,7 @@
  */
 class ConfigService
 {
-    /**
-     * @var array<string, mixed>
-     */
-    private array $config;
+    private CognitiveConfig $config;
 
     /**
      * @SuppressWarnings(PHPMD)
@@ -24,24 +21,36 @@ public function __construct(
         private readonly Processor $processor,
         private readonly ConfigLoader $configuration
     ) {
-        $this->config = $this->processor->processConfiguration($this->configuration, [
+        $this->loadDefaultConfig();
+    }
+
+    /**
+     * @SuppressWarnings(PHPMD)
+     */
+    private function loadDefaultConfig(): void
+    {
+        $config = $this->processor->processConfiguration($this->configuration, [
             Yaml::parseFile(__DIR__ . '/../../config.yml'),
         ]);
+
+        $this->config = (new ConfigFactory())->fromArray($config);
     }
 
     /**
      * @SuppressWarnings(PHPMD)
      */
     public function loadConfig(string $configFilePath): void
     {
-        $this->config = $this->processor->processConfiguration($this->configuration, [
+        $config = $this->processor->processConfiguration($this->configuration, [
             Yaml::parseFile(__DIR__ . '/../../config.yml'),
             Yaml::parseFile($configFilePath),
         ]);
+
+        $this->config = (new ConfigFactory())->fromArray($config);
     }
 
     public function getConfig(): CognitiveConfig
     {
-        return (new ConfigFactory())->fromArray($this->config);
+        return $this->config;
     }
 }