Add constructor parameter validation to both rules

PropertyMustMatchRule now validates that propertyPatterns is non-empty.
ForbiddenAccessorsRule now validates that classPatterns is non-empty and
that visibility values are valid (public, protected, private). Invalid
configurations now throw InvalidArgumentException immediately instead
of silently producing no results.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: Florian Krämer

src/Architecture/ForbiddenAccessorsRule.php

@@ -40,6 +40,8 @@ class ForbiddenAccessorsRule implements Rule
     private const GETTER_PATTERN = '/^get[A-Z]/';
     private const SETTER_PATTERN = '/^set[A-Z]/';
 
+    private const VALID_VISIBILITIES = ['public', 'protected', 'private'];
+
     /**
      * @param array<string> $classPatterns Regex patterns to match against class FQCNs.
      * @param bool $forbidGetters Whether to forbid getXxx() methods.
@@ -52,6 +54,20 @@ public function __construct(
         protected bool $forbidSetters = true,
         protected array $visibility = ['public']
     ) {
+        if ($classPatterns === []) {
+            throw new \InvalidArgumentException('At least one class pattern must be provided.');
+        }
+
+        $invalidVisibilities = array_diff($this->visibility, self::VALID_VISIBILITIES);
+        if ($invalidVisibilities !== []) {
+            throw new \InvalidArgumentException(
+                sprintf(
+                    'Invalid visibility value(s): %s. Must be one of: %s.',
+                    implode(', ', $invalidVisibilities),
+                    implode(', ', self::VALID_VISIBILITIES)
+                )
+            );
+        }
     }
 
     public function getNodeType(): string

src/Architecture/PropertyMustMatchRule.php

@@ -64,6 +64,9 @@ class PropertyMustMatchRule implements Rule
     public function __construct(
         protected array $propertyPatterns
     ) {
+        if ($propertyPatterns === []) {
+            throw new \InvalidArgumentException('At least one property pattern must be provided.');
+        }
     }
 
     public function getNodeType(): string