WIP: Support TerminologySets#2425
Draft
slifty wants to merge 4 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2189-use-opportunity-factory #2425 +/- ##
================================================================
+ Coverage 93.54% 93.59% +0.04%
================================================================
Files 301 310 +9
Lines 3826 3933 +107
Branches 513 509 -4
================================================================
+ Hits 3579 3681 +102
- Misses 246 251 +5
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
🔎 A preview deployment of this pull request is available at https://utilities.philanthropydatacommons.org/pdc-service-preview-2425-455oi/ (and upstream https://pdc-service-preview-2425-455oi.ondigitalocean.app) assuming this PR is still open. 🔍 |
slifty
force-pushed
the
2330-support-terminology-sets
branch
from
a3ce2fe to
fe7ba31
Compare
The PermissionGrants.ts file was getting really big (and the linter was about to get upset). This change breaks it across reasonable boundaries to make it easier to interact with.
This expands the permission system making it possible to grant a permission to all authenticated users. If a permission of this type has been granted it will apply to all logged in users regardless of their user group. Issue #1774 Support "universal" permission grants
This helps us consolidate common logic used across permission check queries. The resulting queries are cleaner and this also ensures grantee checks are consistent across permission queries.
slifty
force-pushed
the
2330-support-terminology-sets
branch
from
fe7ba31 to
cdebfee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.