Allow blank file attachments in bulk upload#2430
Open
hminsky2002 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates bulk upload processing so that file-typed fields can be left blank in the CSV without causing the entire bulk upload task to fail (issue #2429).
Changes:
- Skip attachment lookup/conversion for
FILEfields when the CSV cell is blank. - Add an integration test + CSV fixture covering a blank file attachment cell.
- Document the behavior change in the changelog.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/tasks/processBulkUploadTask.ts | Avoids attempting attachment lookup when a FILE field value is blank. |
| src/tasks/tests/processBulkUploadTask.int.test.ts | Adds an integration test verifying bulk upload completes with a blank file cell. |
| src/tasks/tests/fixtures/processBulkUploadTask/validCsvTemplateWithBlankFile.csv | New fixture CSV containing a blank favorite_file cell. |
| CHANGELOG.md | Notes the bulk upload fix for blank file-typed fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
636
to
642
| if ( | ||
| applicationFormField.baseField.dataType === BaseFieldDataType.FILE | ||
| applicationFormField.baseField.dataType === | ||
| BaseFieldDataType.FILE && | ||
| fieldValue !== '' | ||
| ) { | ||
| const attachmentFile = | ||
| await attachmentsManager.getAttachmentFile(fieldValue); |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2430 +/- ##
=======================================
Coverage 93.56% 93.56%
=======================================
Files 303 303
Lines 3838 3840 +2
Branches 515 518 +3
=======================================
+ Hits 3591 3593 +2
Misses 246 246
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This commit allows for a bulk upload to proceed when a cell is blank for a file. This was a requested feature for the service by @grant-minor-sntialtech ! Issue #2429 Allow null or blank file attachments for some rows in bulk upload
hminsky2002
force-pushed
the
2429-allow-blank-file-attachments
branch
from
73eaeea to
b501144
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit allows for a bulk upload to proceed when a cell is blank for a file instead of erroring out!
Closes #2429