stability improvements

Author: PhilippC

src/Kp2aBusinessLogic/Utils/ExceptionUtil.cs

@@ -12,20 +12,21 @@ public class ExceptionUtil
 
         public static string GetErrorMessage(Exception e)
         {
-            string errorMessage = e.Message;
-            if (e is Java.Lang.Exception javaException)
+
+            try
             {
-                try
+                string errorMessage = e.Message;
+                if (e is Java.Lang.Exception javaException)
                 {
                     errorMessage = javaException.LocalizedMessage ?? javaException.Message ?? errorMessage;
                 }
-                finally
-                {
 
-                }
+                return errorMessage;
+            }
+            catch
+            {
+                return "";
             }
-
-            return errorMessage;
         }
 
     }

src/keepass2android-app/views/PwEntryView.cs

@@ -131,7 +131,15 @@ private void PopulateView(View ev, PwEntry pw, int pos)
 		    ev.FindViewById(Resource.Id.icon).Visibility = ViewStates.Visible;
 		    ev.FindViewById(Resource.Id.check_mark).Visibility = ViewStates.Invisible;
 
-		    _db = App.Kp2a.FindDatabaseForElement(_entry);
+		    _db = App.Kp2a.TryFindDatabaseForElement(_entry);
+            if (_db == null)
+            {
+                ev.FindViewById(Resource.Id.icon).Visibility = ViewStates.Gone;
+                _textView.TextFormatted = new SpannableString("(no data)");
+                _textviewDetails.Visibility = ViewStates.Gone;
+                _textgroupFullPath.Visibility = ViewStates.Gone;
+                return;
+            }
 
             ImageView iv = (ImageView)ev.FindViewById(Resource.Id.icon);
 			bool isExpired = pw.Expires && pw.ExpiryTime < DateTime.Now;
@@ -209,11 +217,6 @@ private void PopulateView(View ev, PwEntry pw, int pos)
             UpdateTotp();
 
 
-           
-                
-
-            
-
         }
 
 		public void ConvertView(PwEntry pw, int pos)

src/keepass2android-app/views/PwGroupView.cs

@@ -15,14 +15,15 @@ You should have received a copy of the GNU General Public License
   along with Keepass2Android.  If not, see <http://www.gnu.org/licenses/>.
   */
 
-using System;
 using Android.Graphics;
 using Android.OS;
 using Android.Runtime;
+using Android.Text;
 using Android.Views;
 using Android.Widget;
 using keepass2android;
 using KeePassLib;
+using System;
 using Object = Java.Lang.Object;
 
 namespace keepass2android.view
@@ -64,7 +65,20 @@ private PwGroupView(GroupBaseActivity act, PwGroup pw)
 			_label = (TextView) gv.FindViewById(Resource.Id.group_label);
 			_label.TextSize = size-8;
 
-		    Database db = App.Kp2a.FindDatabaseForElement(pw);
+		    Database db = App.Kp2a.TryFindDatabaseForElement(pw);
+
+            
+            if (db == null)
+            {
+
+                gv.FindViewById(Resource.Id.group_icon_bkg).Visibility = ViewStates.Gone;
+
+                gv.FindViewById(Resource.Id.icon).Visibility = ViewStates.Gone;
+                gv.FindViewById(Resource.Id.check_mark).Visibility = ViewStates.Invisible;
+                _textview.Text = "(no data)";
+                _label.Text = "";
+                return;
+            }
 
             gv.FindViewById(Resource.Id.group_icon_bkg).Visibility = db.DrawableFactory.IsWhiteIconSet ? ViewStates.Visible : ViewStates.Gone;