Adds support for Android companion pairing, device bonding, iOS device name (via GAP)#760
Open
ened wants to merge 21 commits into
Open
Adds support for Android companion pairing, device bonding, iOS device name (via GAP)#760ened wants to merge 21 commits into
ened wants to merge 21 commits into
Conversation
ened
force-pushed
the
android-companion-and-bonding
branch
from
edc4b1b to
d292562
Compare
ened
changed the title
remonh87
suggested changes
Jul 7, 2023
remonh87
left a comment
remonh87
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR I think it will be a great addition to the library. I will look into the implementation further this weekend but had now half hour time to overlook the structure. I am a bit concerned about adding the bond mode to connect method. Maybe it is better we add a specific method for companion pairing.
remonh87
suggested changes
Jul 8, 2023
Contributor
There was a problem hiding this comment.
Now the full review: again thank you very much for implementing this I think it is close to be integrated. Please check out my remarks. Also some generic things:
- Add unit tests for the compianonflow on dart
- Add unit tests for the protobuf conversion methods related to device name and companion flow
- Document the public methods Especially with
createBondit is important that we emphasise that this will only work on android.
Reach out if you need help
|
|
||
| override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?): Boolean { | ||
| if (requestCode == CompanionHandler.SELECT_DEVICE_REQUEST_CODE && resultCode == Activity.RESULT_OK) { | ||
| Log.d(TAG, "received result from device selection activity, parsing via companion handler") |
Contributor
There was a problem hiding this comment.
let's remove the debug logs
- remove debug logs
|
|
||
| @RequiresApi(Build.VERSION_CODES.O) | ||
| fun onActivityResult(data: Intent?): ScanResult? { | ||
| Log.d(TAG, "onActivityResult: $data") |
Contributor
There was a problem hiding this comment.
let's also remove here the debug logging
werediver
reviewed
Jul 10, 2023
| } | ||
| completion(.success(message)) | ||
| } catch { | ||
| completion(.success(nil)) |
Collaborator
There was a problem hiding this comment.
This branch doesn't look like success to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #272, #628, #641 in the same PR.
For a project, I needed multiple additions, so the code is quite mixed.
Let's look at this PR holistically first. (I needed both sets of functionality for a project).
Whole set of changes:
CBPeripheral.namemethod, partially addresses Provide separate access to device name in Generic Access Profile and Advertisement Data. #641scan- from my App, which is great)