swiftlint config and inital formatting pass#765
Merged
Conversation
ened
changed the title
Contributor
Author
|
cc @werediver |
werediver
approved these changes
Jul 10, 2023
| - Pods | ||
| - "**/*.pb.swift" # exclude files with a wildcard | ||
|
|
||
| line_length: 300 |
Collaborator
There was a problem hiding this comment.
I doubt we have lines longer than 120 characters, but... if it was not enforced or checked, who knows.
Contributor
Author
There was a problem hiding this comment.
I added it so that there are no warnings (we have a few). The ruleset could be reduced and refined with future PRs (out of scope for this one IMHO).
Contributor
Author
|
@werediver need your help to merge it, please :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial stab at formatting as discussed in #760
This is not integrated in CI/CD yet, but only tries to do light formatting to get started.
cc @remonh87 @Taym95