Fix issues with AITargetTypes and add new one only for bridge repair huts

- Tech building now only requires Capturable=true + NeedsEngineer=true and skips checking NeutralTechBuildings and other keys
- Bridge repair huts no longer check Repairable and instead check if they are linked to broken bridges
- Team leader guard area uses the getter function instead of reading GuardRange from type

Author: Starkku

docs/AI-Scripting-and-Mapping.md

@@ -185,7 +185,7 @@ x=i,n             ; For i values check the next table
 | 8       | House Threats            | Any object that targets anything of the Team's House or any enemy that is near to the Team Leader |
 | 9       | Power Plants             | Any enemy `BuildingTypes` with positive `Power=` values |
 | 10      | Occupied                 | Any `BuildingTypes` with garrisoned infantry |
-| 11      | Tech Buildings           | Any `BuildingTypes` with `Unsellable=yes`, `Capturable=yes`, negative `TechLevel=` values or appears in `[AI] -> NeutralTechBuildings=` list |
+| 11      | Tech Buildings           | Any `BuildingTypes` with `Capturable=yes` and `NeedsEngineer=yes` |
 | 12      | Refinery                 | Any enemy `BuildingTypes` with `Refinery=yes` or `ResourceGatherer=yes`, `VehicleTypes` with `ResourceGatherer=yes` & `Harvester=no` (i.e. Slave Miner) |
 | 13      | Mind Controller          | Anything `VehicleTypes`, `AircraftTypes`, `InfantryTypes` and `BuildingTypes` with `MindControl=yes` in the weapons Warheads |
 | 14      | Air Units (incl. landed) | Any enemy, `AircraftTypes` and `Jumpjet=yes` `VehicleTypes` or `InfantryTypes`, including landed ones as well as any other currently airborne units |
@@ -207,10 +207,11 @@ x=i,n             ; For i values check the next table
 | 30      | Inhibitors               | Any enemy objects with positive `InhibitorRange=` values |
 | 31      | Naval Units              | Any enemy `VehicleTypes` with a `Naval=yes` or any enemy `VehicleTypes`, `AircraftTypes`, `InfantryTypes` in a water cell |
 | 32      | Mobile Units             | Anything `VehicleTypes`, `AircraftTypes` and `InfantryTypes` |
-| 33      | Capturable               | Any `BuildingTypes` with `Capturable=yes` or any `BuildingTypes` with `BridgeRepairHut=yes` and `Repairable=yes` |
+| 33      | Capturable               | Any `BuildingTypes` with `Capturable=yes` or any `BuildingTypes` with `BridgeRepairHut=yes` that are linked to broken bridges |
 | 34      | Area Threats             | Any enemy object that is inside of the Team Leader's Guard Area |
 | 35      | Vehicle & Naval Factory  | Any enemy `BuildingTypes` with `Factory=UnitType` |
 | 36      | Non-defensive Structures | Any enemy `BuildingTypes` with `IsBaseDefense=no` |
+| 37      | Bridge Repair Huts       | Any `BuildingTypes`with `BridgeRepairHut=yes` that are linked to broken bridges |
 
 - The second parameter with a 0-based index for the `AITargetTypes` section specifies the list of possible `VehicleTypes`, `AircraftTypes`, `InfantryTypes` and `BuildingTypes` that can be evaluated.
 - The *`AITargetTypes` index#* values are obtained in the new `AITargetTypes` section that must be declared in `rulesmd.ini`:

src/Ext/Script/Mission.Attack.cpp

@@ -871,26 +871,8 @@ bool ScriptExt::EvaluateObjectWithMask(TechnoClass* pTechno, int mask, int attac
 
 		if (const auto pBuildingType = abstract_cast<BuildingTypeClass*, true>(pTechnoType))
 		{
-			const auto& neutralTechBuildings = RulesClass::Instance->NeutralTechBuildings;
-
-			if (const int count = neutralTechBuildings.Count)
-			{
-				for (int i = 0; i < count; ++i)
-				{
-					if (neutralTechBuildings.GetItem(i) == pTechnoType)
-						return true;
-				}
-			}
-
-			// Other cases of civilian Tech Structures
-			if (pBuildingType->Unsellable
-				&& pBuildingType->Capturable
-				&& pBuildingType->TechLevel < 0
-				&& pBuildingType->NeedsEngineer
-				&& !pBuildingType->BridgeRepairHut)
-			{
+			if (pBuildingType->Capturable && pBuildingType->NeedsEngineer)
 				return true;
-			}
 		}
 
 		break;
@@ -1300,7 +1282,7 @@ bool ScriptExt::EvaluateObjectWithMask(TechnoClass* pTechno, int mask, int attac
 		{
 			if (pBuildingType->Capturable
 				|| (pBuildingType->BridgeRepairHut
-					&& pBuildingType->Repairable))
+					&& MapClass::Instance.IsLinkedBridgeDestroyed(pTechno->GetMapCoords())))
 			{
 				return true;
 			}
@@ -1313,14 +1295,8 @@ bool ScriptExt::EvaluateObjectWithMask(TechnoClass* pTechno, int mask, int attac
 
 		if (pTeamLeader && !pTechno->Owner->IsNeutral())
 		{
-			const int distanceToTarget = pTeamLeader->DistanceFrom(pTechno);
-			const int guardRange = pTeamLeader->GetTechnoType()->GuardRange;
-
-			if (guardRange > 0
-				&& distanceToTarget <= (guardRange * 2))
-			{
+			if (pTeamLeader->DistanceFrom(pTechno) <= pTeamLeader->GetGuardRange(1))
 				return true;
-			}
 		}
 
 		break;
@@ -1356,6 +1332,20 @@ bool ScriptExt::EvaluateObjectWithMask(TechnoClass* pTechno, int mask, int attac
 
 		break;
 
+	case 37:
+		// Bridge Repair Hut
+
+		if (const auto pBuildingType = abstract_cast<BuildingTypeClass*, true>(pTechnoType))
+		{
+			if (pBuildingType->BridgeRepairHut
+				&& MapClass::Instance.IsLinkedBridgeDestroyed(pTechno->GetMapCoords()))
+			{
+				return true;
+			}
+		}
+
+		break;
+
 	default:
 		break;
 	}