Fixed voxel projectile and animation lighting issues (#2228)

In vanilla, they are darker than voxel technos.

---------

Co-authored-by: Noble_Fish <1065703286@qq.com>

Author: TaranDahl

CREDITS.md

@@ -760,6 +760,7 @@ This page lists all the individual contributions to the project by their author.
   - Allow replacing vanilla repairing with togglable auto repairing
   - Fix an issue that the time for units in the area guard mission to reacquire targets after eliminating the target is significantly longer than that in other missions
   - Framework for dynamic sight
+  - Fixed voxel projectile and animation lighting issues
 - **solar-III (凤九歌)**
   - Target scanning delay customization (documentation)
   - Skip target scanning function calling for unarmed technos (documentation)

YRpp

@@ -326,6 +326,7 @@ This page describes all ingame logics that are fixed or improved in Phobos witho
 - Purely visual animations and particles are no longer included in frame CRC generation and are thus exempt from any sync checks between players in multiplayer games.
 - Fixed the bug that low-air taking off / landing objects will receive twice damage.
 - Allowed `AuxBuilding` to count building upgrades.
+- Fixed voxel projectile and animation lighting issues.
 
 ## Fixes / interactions with other extensions
 

docs/Fixed-or-Improved-Logics.md

@@ -659,6 +659,7 @@ HideShakeEffects=false           ; boolean
 - Fixed AI team recruitment inconsistency causing underfilled teams (by handama)
 - Fixed the issue where tint color RGB mode conversion was incorrect (by Shatyuka)
 - Fixed the bug that low-air taking off / landing objects will receive twice damage (by NetsuNegi)
+- Fixed voxel projectile and animation lighting issues (by TaranDahl)
 
 #### Phobos fixes:
 - Fixed the bug that `AllowAirstrike=no` cannot completely prevent air strikes from being launched against it (by NetsuNegi)

docs/Whats-New.md

@@ -2547,6 +2547,10 @@ msgstr "修复了处于 `Area Guard` 任务中的单位消灭目标后重新获
 msgid "Framework for dynamic sight"
 msgstr "动态视野框架"
 
+msgid ""
+"Fixed voxel projectile and animation lighting issues"
+msgstr "修复了 Voxel 抛射体和动画的光照问题"
+
 msgid "**solar-III (凤九歌)**"
 msgstr "**solar-III（凤九歌）**"
 

docs/locale/zh_CN/LC_MESSAGES/CREDITS.po

@@ -1686,6 +1686,10 @@ msgstr "修复了低空起飞／降落的物体会受到两次伤害的 Bug。"
 msgid "Allowed `AuxBuilding` to count building upgrades."
 msgstr "允许了 `AuxBuilding` 计入建筑加载物。"
 
+msgid ""
+"Fixed voxel projectile and animation lighting issues."
+msgstr "修复了 Voxel 抛射体和动画的光照问题。"
+
 msgid "Fixes / interactions with other extensions"
 msgstr "修复或与其他扩展的交互"
 

docs/locale/zh_CN/LC_MESSAGES/Fixed-or-Improved-Logics.po

@@ -2366,6 +2366,10 @@ msgid ""
 "twice damage (by NetsuNegi)"
 msgstr "修复了低空起飞／降落的物体会受到两次伤害的 Bug（by NetsuNegi）"
 
+msgid ""
+"Fixed voxel projectile and animation lighting issues (by TaranDahl)"
+msgstr "修复了 Voxel 抛射体和动画的光照问题（by TaranDahl）"
+
 msgid "Phobos fixes:"
 msgstr "Phobos 过往版本问题修复："
 

docs/locale/zh_CN/LC_MESSAGES/Whats-New.po

@@ -3552,3 +3552,29 @@ DEFINE_HOOK(0x71A9CD, Remove_UnInitFix, 0x6) // TemporalClass::Update
 	pPassenger->UnInit();
 	return R->Origin() + 0x9;
 }
+
+#pragma region VoxelLightingFix
+
+// Fixes VoxelAnimClass::DrawIt and BulletClass::DrawAVXL VXL rendering
+// lacking proper double-light source (ambient + directional + specular)
+// that TechnoClass uses via sub_753D00, making them appear darker.
+
+DEFINE_HOOK(0x749D97, VoxelAnimClass_DrawIt_LightingFix, 0x5)
+{
+	GET(VoxLib*, pVXL, EBP);
+	GET(Matrix3D*, pMatrix, EAX);
+	Drawing::SetupVoxelDoubleLighting(pVXL, 0, 0, pMatrix, &Drawing::VoxelTransformMatrix, &Game::VoxelLightSource, 3.0);
+	return 0x749DA8;
+}
+
+DEFINE_HOOK(0x46B0E1, BulletClass_DrawAVXL_LightingFix, 0x5)
+{
+	GET(VoxLib*, pVXL, ESI);
+	GET(Matrix3D*, pMatrix, EAX);
+
+	Drawing::SetupVoxelDoubleLighting(pVXL, 0, 0, pMatrix, &Drawing::VoxelTransformMatrix, &Game::VoxelLightSource, 3.0);
+	R->Stack(STACK_OFFSET(0xF4, -0xDC), pVXL);
+	return 0x46B0F6;
+}
+
+#pragma endregion