Remove meaningless globals inside globals

VectorNames was used for rmg and now useless

Author: chaserli

src/Ext/Rules/Body.cpp

@@ -428,17 +428,6 @@ void RulesExt::ExtData::ReplaceVoxelLightSources()
 		Game::DestroyVoxelCaches();
 }
 
-
-bool RulesExt::LoadGlobals(PhobosStreamReader& Stm)
-{
-	return Stm.Success();
-}
-
-bool RulesExt::SaveGlobals(PhobosStreamWriter& Stm)
-{
-	return Stm.Success();
-}
-
 // =============================
 // container hooks
 

src/Ext/Rules/Body.h

@@ -332,7 +332,4 @@ class RulesExt
 		Global()->InvalidatePointer(ptr, removed);
 	}
 
-	static bool LoadGlobals(PhobosStreamReader& Stm);
-	static bool SaveGlobals(PhobosStreamWriter& Stm);
-
 };

src/Ext/Scenario/Body.cpp

@@ -177,17 +177,6 @@ void ScenarioExt::ExtData::SaveToStream(PhobosStreamWriter& Stm)
 	this->Serialize(Stm);
 }
 
-bool ScenarioExt::LoadGlobals(PhobosStreamReader& Stm)
-{
-	return Stm.Success();
-}
-
-bool ScenarioExt::SaveGlobals(PhobosStreamWriter& Stm)
-{
-	return Stm.Success();
-}
-
-
 // =============================
 // container hooks
 

src/Ext/Scenario/Body.h

@@ -94,6 +94,4 @@ class ScenarioExt
 		Global()->InvalidatePointer(ptr, removed);
 	}
 
-	static bool LoadGlobals(PhobosStreamReader& Stm);
-	static bool SaveGlobals(PhobosStreamWriter& Stm);
 };

src/Ext/Sidebar/Body.cpp

@@ -36,16 +36,6 @@ void SidebarExt::ExtData::SaveToStream(PhobosStreamWriter& Stm)
 	this->Serialize(Stm);
 }
 
-bool SidebarExt::LoadGlobals(PhobosStreamReader& Stm)
-{
-	return Stm.Success();
-}
-
-bool SidebarExt::SaveGlobals(PhobosStreamWriter& Stm)
-{
-	return Stm.Success();
-}
-
 
 // =============================
 // container hooks

src/Ext/Sidebar/Body.h

@@ -58,7 +58,4 @@ class SidebarExt
 	{
 		Global()->InvalidatePointer(ptr, removed);
 	}
-
-	static bool LoadGlobals(PhobosStreamReader& Stm);
-	static bool SaveGlobals(PhobosStreamWriter& Stm);
 };

src/Utilities/Constructs.h

@@ -134,81 +134,6 @@ class CustomPalette
 	void CreateConvert();
 };
 
-// vector of char* with builtin storage
-class VectorNames
-{
-protected:
-	DynamicVectorClass<const char*> Strings;
-	char* Buffer { nullptr };
-
-public:
-	VectorNames() = default;
-
-	VectorNames(const char* pBuffer)
-	{
-		this->Tokenize(pBuffer);
-	}
-
-	~VectorNames()
-	{
-		this->Clear();
-	}
-
-	const char* operator[] (int index) const
-	{
-		return this->Strings.GetItemOrDefault(index);
-	}
-
-	const DynamicVectorClass<const char*>& Entries() const
-	{
-		return this->Strings;
-	}
-
-	const char** ToString() const
-	{
-		return this->Strings.Items;
-	}
-
-	int Count() const
-	{
-		return this->Strings.Count;
-	}
-
-	void Clear()
-	{
-		if (this->Buffer)
-		{
-			this->Strings.Clear();
-			free(this->Buffer);
-			this->Buffer = nullptr;
-		}
-	}
-
-	void Tokenize()
-	{
-		if (this->Buffer)
-		{
-			this->Strings.Clear();
-
-			char* context = nullptr;
-			for (auto cur = strtok_s(this->Buffer, ",", &context); cur && *cur; cur = strtok_s(nullptr, ",", &context))
-			{
-				this->Strings.AddItem(cur);
-			}
-		}
-	}
-
-	void Tokenize(const char* pBuffer)
-	{
-		if (pBuffer)
-		{
-			this->Clear();
-			this->Buffer = _strdup(pBuffer);
-			this->Tokenize();
-		}
-	}
-};
-
 // a poor man's map with contiguous storage
 template <typename TKey, typename TValue>
 class PhobosMap

src/Utilities/TemplateDef.h

@@ -53,9 +53,7 @@
 #include <VoxClass.h>
 #include <CRT.h>
 #include <LocomotionClass.h>
-#ifdef CUSTOM_LOCO_EXAMPLE_ENABLED
 #include <Locomotion/TestLocomotionClass.h>
-#endif
 
 namespace detail
 {