Skip to content

OpenTopped moving fire customization#2283

Open
Coronia wants to merge 2 commits into
Phobos-developers:developfrom
Coronia:opentopped-moving-fire
Open

OpenTopped moving fire customization#2283
Coronia wants to merge 2 commits into
Phobos-developers:developfrom
Coronia:opentopped-moving-fire

Conversation

@Coronia

@Coronia Coronia commented Jul 6, 2026

Copy link
Copy Markdown
Contributor
  • Whether or not a passenger's weapon can fire out from an OpenTopped=yes transport will now respect the weapon's FireWhileMoving setting.
  • OpenTopped/OpenTransport.FireWhileMoving can be used to customize whether or not passengers can fire out when the transport is moving, for transport and passenger respectively. Both of them and the weapon's FireWhileMoving toggle need to be set to true to allow firing out when moving.

In rulesmd.ini:

[General]
OpenTopped.FireWhileMoving=true                   ; boolean
OpenTransport.FireWhileMoving=true                ; boolean

[SOMETECHNO]                                      ; TechnoType, transport with OpenTopped=yes
OpenTopped.FireWhileMoving=                       ; boolean, defaults to [General] -> OpenTopped.FireWhileMoving

[SOMETECHNO]                                      ; TechnoType, passenger
OpenTransport.FireWhileMoving=                    ; boolean, defaults to [General] -> OpenTransport.FireWhileMoving

@Coronia Coronia added Needs testing ⚙️T1 T1 maintainer review is sufficient labels Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@Starkku

Starkku commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

This technically works little bit different from actual OpportunityFire which contrary to its name actually affects target scanning not firing. Whether or not the distinction is important I am uncertain about, though.

It might be more sensible to use name like AllowFireWhileMoving or whatever since that one explicitly affects firing and is more similar to this in concept. Vanilla code FireWhileMoving also returns FireError::MOVING instead of FireError::ILLEGAL like you are currently doing but I am unsure if the OpenTopped context changes requirements here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs testing ⚙️T1 T1 maintainer review is sufficient

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants