You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Whether or not a passenger's weapon can fire out from an OpenTopped=yes transport will now respect the weapon's FireWhileMoving setting.
OpenTopped/OpenTransport.FireWhileMoving can be used to customize whether or not passengers can fire out when the transport is moving, for transport and passenger respectively. Both of them and the weapon's FireWhileMoving toggle need to be set to true to allow firing out when moving.
In rulesmd.ini:
[General]OpenTopped.FireWhileMoving=true ; booleanOpenTransport.FireWhileMoving=true ; boolean[SOMETECHNO]; TechnoType, transport with OpenTopped=yesOpenTopped.FireWhileMoving= ; boolean, defaults to [General] -> OpenTopped.FireWhileMoving[SOMETECHNO]; TechnoType, passengerOpenTransport.FireWhileMoving= ; boolean, defaults to [General] -> OpenTransport.FireWhileMoving
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.
This technically works little bit different from actual OpportunityFire which contrary to its name actually affects target scanning not firing. Whether or not the distinction is important I am uncertain about, though.
It might be more sensible to use name like AllowFireWhileMoving or whatever since that one explicitly affects firing and is more similar to this in concept. Vanilla code FireWhileMoving also returns FireError::MOVING instead of FireError::ILLEGAL like you are currently doing but I am unsure if the OpenTopped context changes requirements here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenTopped=yestransport will now respect the weapon'sFireWhileMovingsetting.OpenTopped/OpenTransport.FireWhileMovingcan be used to customize whether or not passengers can fire out when the transport is moving, for transport and passenger respectively. Both of them and the weapon'sFireWhileMovingtoggle need to be set to true to allow firing out when moving.In
rulesmd.ini: