feat(sunshine): add Prism Launcher (Minecraft)#337
Open
gabbelitoV2 wants to merge 3 commits into
Open
Conversation
Owner
|
Hi there ! Thanks again for this contribution. Adding this launcher is great, though I fear our base image would become too gid. What would be nice is to add the ability to add this launcher on-demand after initial setup: a simple command or button to click and it would install everything, using most of the code you have here. It's also an overall design decision for how to add launchers on-the-fly. I'll try to think of something ASAP |
gabbelitoV2
force-pushed
the
add-prismlauncher
branch
from
c2894ad to
37810da
Compare
gabbelitoV2
force-pushed
the
add-prismlauncher
branch
from
37810da to
abeddcd
Compare
Contributor
Author
|
What do you think—is there anything I should change? |
Owner
|
hi @gabbelitoV2 I'm sorry I just haven't had time to look into this yet... |
Contributor
Author
|
okay i hope you look into this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Prism Launcher (Minecraft) to the Sunshine container.
Changes
Testing