feat: add 3D textures for gfx ext (v2.1.0)

Author: hoffstadt-nasa

docs/version.txt

@@ -59,7 +59,7 @@ the API is complete. It just means we won't break what currently exists.
 * Draw                v3.0.0  (pl_draw_ext.h)
 * DXT                 v2.0.0  (pl_dxt_ext.h)
 * GPU Allocators      v1.1.1  (pl_gpu_allocators_ext.h)
-* Graphics            v2.0.1  (pl_graphics_ext.h)
+* Graphics            v2.1.0  (pl_graphics_ext.h)
 * Image               v1.2.0  (pl_image_ext.h)
 * Job                 v2.3.0  (pl_job_ext.h)
 * Atomics             v2.0.0  (pl_platform_ext.h)

extensions/pl_graphics_ext.h

@@ -121,7 +121,7 @@ extern "C" {
 // [SECTION] apis
 //-----------------------------------------------------------------------------
 
-#define plGraphicsI_version {2, 0, 1}
+#define plGraphicsI_version {2, 1, 0}
 
 //-----------------------------------------------------------------------------
 // [SECTION] includes
@@ -1404,6 +1404,7 @@ enum _plTextureType
 {
     PL_TEXTURE_TYPE_UNSPECIFIED,
     PL_TEXTURE_TYPE_2D,
+    PL_TEXTURE_TYPE_3D,
     PL_TEXTURE_TYPE_CUBE,
     PL_TEXTURE_TYPE_2D_ARRAY
 };

extensions/pl_graphics_metal.m

@@ -617,6 +617,8 @@
 
     if(tDesc.eType == PL_TEXTURE_TYPE_2D)
         ptTextureDescriptor.textureType = MTLTextureType2D;
+    else if(tDesc.eType == PL_TEXTURE_TYPE_3D)
+        ptTextureDescriptor.textureType = MTLTextureType3D;
     else if(tDesc.eType == PL_TEXTURE_TYPE_CUBE)
         ptTextureDescriptor.textureType = MTLTextureTypeCube;
     else if(tDesc.eType == PL_TEXTURE_TYPE_2D_ARRAY)
@@ -942,6 +944,8 @@
 
     if(ptNewTexture->tDesc.eType == PL_TEXTURE_TYPE_2D)
         tTextureType = MTLTextureType2D;
+    else if(ptNewTexture->tDesc.eType == PL_TEXTURE_TYPE_3D)
+        tTextureType = MTLTextureType3D;
     else if(ptNewTexture->tDesc.eType == PL_TEXTURE_TYPE_CUBE)
         tTextureType = MTLTextureTypeCube;
     else if(ptNewTexture->tDesc.eType == PL_TEXTURE_TYPE_2D_ARRAY)

extensions/pl_graphics_vulkan.c

@@ -1327,6 +1327,8 @@ pl_graphics_create_texture(plDevice* ptDevice, const plTextureDesc* ptDesc, plTe
     VkImageViewType tImageViewType = 0;
     if (tDesc.eType == PL_TEXTURE_TYPE_CUBE)
         tImageViewType = VK_IMAGE_VIEW_TYPE_CUBE;
+    else if (tDesc.eType == PL_TEXTURE_TYPE_3D)
+        tImageViewType = VK_IMAGE_VIEW_TYPE_3D;
     else if (tDesc.eType == PL_TEXTURE_TYPE_2D)
         tImageViewType = VK_IMAGE_VIEW_TYPE_2D;
     else if (tDesc.eType == PL_TEXTURE_TYPE_2D_ARRAY)
@@ -1350,7 +1352,7 @@ pl_graphics_create_texture(plDevice* ptDevice, const plTextureDesc* ptDesc, plTe
 
     const VkImageCreateInfo tImageInfo = {
         .sType         = VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO,
-        .imageType     = VK_IMAGE_TYPE_2D,
+        .imageType     = tDesc.eType == PL_TEXTURE_TYPE_3D ? VK_IMAGE_TYPE_3D : VK_IMAGE_TYPE_2D,
         .extent.width  = (uint32_t)tDesc.tDimensions.x,
         .extent.height = (uint32_t)tDesc.tDimensions.y,
         .extent.depth  = (uint32_t)tDesc.tDimensions.z,
@@ -1410,6 +1412,8 @@ pl_graphics_bind_texture_to_memory(plDevice* ptDevice, plTextureHandle tHandle,
         tImageViewType = VK_IMAGE_VIEW_TYPE_2D;
     else if (ptTexture->tDesc.eType == PL_TEXTURE_TYPE_2D_ARRAY)
         tImageViewType = VK_IMAGE_VIEW_TYPE_2D_ARRAY;
+    else if (ptTexture->tDesc.eType == PL_TEXTURE_TYPE_3D)
+        tImageViewType = VK_IMAGE_VIEW_TYPE_3D;
     else
     {
         PL_ASSERT(false && "unsupported texture type");
@@ -1530,6 +1534,8 @@ pl_graphics_create_texture_view(plDevice* ptDevice, const plTextureViewDesc* ptV
         tImageViewType = VK_IMAGE_VIEW_TYPE_CUBE;
     else if (ptNewTexture->tDesc.eType == PL_TEXTURE_TYPE_2D)
         tImageViewType = VK_IMAGE_VIEW_TYPE_2D;
+    else if (ptNewTexture->tDesc.eType == PL_TEXTURE_TYPE_3D)
+        tImageViewType = VK_IMAGE_VIEW_TYPE_3D;
     else if (ptNewTexture->tDesc.eType == PL_TEXTURE_TYPE_2D_ARRAY)
         tImageViewType = VK_IMAGE_VIEW_TYPE_2D; // VK_IMAGE_VIEW_TYPE_2D_ARRAY;
     else
@@ -4274,7 +4280,7 @@ pl_graphics_begin_compute_pass(plCommandBuffer* ptCmdBuffer, const plPassResourc
                         }
                         if(ptTexture->tDesc.eUsage & PL_TEXTURE_USAGE_DEPTH_STENCIL_ATTACHMENT)
                         {
-                            // tSrcStageFlags |= VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT; // TODO: does depth go here?
+                            tSrcStageFlags |= VK_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT | VK_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT; // TODO: does depth go here?
                             tBarrier.srcAccessMask |= VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT;
                         }
                     }
@@ -4363,6 +4369,7 @@ pl_graphics_end_compute_pass(plCommandBuffer* ptCmdBuffer)
                         if(ptTexture->tDesc.eUsage & PL_TEXTURE_USAGE_DEPTH_STENCIL_ATTACHMENT)
                         {
                             // tDstStageFlags |= VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT; // TODO: does depth go here?
+                            tDstStageFlags |= VK_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT | VK_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT;
                             tBarrier.dstAccessMask |= VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT;
                         }
                     }

extensions/pl_renderer_internal.c

@@ -1283,7 +1283,7 @@ pl__renderer_generate_cascaded_shadow_map(plCommandBuffer* ptCommandBuffer, plSc
             const float fCenterZ = 0.5f * (fZMin + fZMax);
 
             // optional z padding for off-frustum casters
-            const float fDepthPadding = 5000.0f; // TODO: make option
+            const float fDepthPadding = 500.0f; // TODO: make option
             const float fNearZ = fZMin - fDepthPadding;
             const float fFarZ  = fZMax + fDepthPadding;