Restore missing default palette colors#2161
Closed
SpaceXItalia wants to merge 1 commit into
Closed
Conversation
Member
These changes don't really address the layout issue from the referenced bug report - attached is a screenshot of what it looks like, which isn't very pleasing to the eye IMO 
The unit test doesn't really add much value either, but is the type of test LLMs will happily generate. I don't think there was any need to use AI here to change the palette colours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores the 14 darker colors that were missing from the default palette, bringing
PaletteHelper.EnumerateDefaultColors()back to 48 colors.The restored colors are inserted alongside their matching hue groups so the palette remains ordered consistently with the current layout while recovering the older default palette coverage.
A focused unit test was added to verify that the default palette contains 48 colors.
Fixes #812.
Tested:
dotnet test tests/Pinta.Core.Tests/Pinta.Core.Tests.csproj --filter DefaultPaletteHasExpectedColorCountThis PR was prepared with AI assistance using OpenAI Codex and manually reviewed before submission.