Fix overlay scrollbar intercepting clicks on selection handles at image edges (#2200)#2201
Conversation
|
Thanks for looking into this! I think the approach here is good; my suggestion would be to generalize it a bit further so that tools don't need to explicitly be aware of and opt into this. For example, the gradient tool also has handles for adjusting the gradient start/end position which shouldn't be blocked by scrollbars One thought would be to avoid the new virtual method and instead check if any of the |
|
Thanks for the feedback! I've reworked the PR along those lines. Instead of the
|
|
The changes look good - thanks! |
This PR fixes #2200 by preventing overlay scrollbars from capturing pointer events when the current tool is interacting with a selection resize handle near the canvas edge.
When a rectangle or ellipse selection reaches the image boundary and the canvas is zoomed in enough for scrollbars to appear, the scrollbar can overlap the resize handle and block interaction. With this change, the selection tool temporarily keeps the scrollbar from targeting pointer events while the cursor is over an active handle, so the handle remains draggable as expected.
I also attached a before/after video showing the problem and the fix in action.
This is my first contribution to Pinta, so I'm not yet familiar with the project's roadmap or preferred development practices. I'm very open to feedback and happy to rework any part of this PR if needed.
before.mp4
after.mp4