add a pio repair and sqlite3 optimize to each release

Author: CamDavidsonPilon

core/pioreactor/cli/pio.py

@@ -422,39 +422,44 @@ def create_commands_for_release_archive(
 
         install_extra = get_install_extra_for_this_unit()
 
+        release_commands.append(
+            update_command(
+                [
+                    "/opt/pioreactor/venv/bin/pip",
+                    "install",
+                    "--no-index",
+                    f"--find-links={tmp_rls_dir}/wheels/",
+                    f"{tmp_rls_dir}/pioreactor-{release_version}-py3-none-any.whl[{install_extra}]",
+                ],
+                3,
+            )
+        )
+
+        release_commands.append(
+            update_command(
+                [
+                    "/opt/pioreactor/venv/bin/pio",
+                    "repair",
+                ],
+                99,
+            )
+        )
+
         if whoami.am_I_leader():
             release_commands.extend(
                 [
-                    update_command(
-                        [
-                            "/opt/pioreactor/venv/bin/pip",
-                            "install",
-                            "--no-index",
-                            f"--find-links={tmp_rls_dir}/wheels/",
-                            f"{tmp_rls_dir}/pioreactor-{release_version}-py3-none-any.whl[{install_extra}]",
-                        ],
-                        3,
-                    ),
                     update_command(
                         ["sudo", "sqlite3", database_path, f".read {tmp_rls_dir}/update.sql"],
                         10,
                         allow_failure=True,
                     ),
+                    update_command(
+                        ["sudo", "sqlite3", database_path, "PRAGMA optimize = 0x10002"],
+                        11,
+                        allow_failure=True,
+                    ),
                 ]
             )
-        else:
-            release_commands.append(
-                update_command(
-                    [
-                        "/opt/pioreactor/venv/bin/pip",
-                        "install",
-                        "--no-index",
-                        f"--find-links={tmp_rls_dir}/wheels/",
-                        f"{tmp_rls_dir}/pioreactor-{release_version}-py3-none-any.whl[{install_extra}]",
-                    ],
-                    3,
-                )
-            )
 
         return release_commands
 

core/tests/test_update_app_commands.py

@@ -194,56 +194,6 @@ def test_app_commands_with_4_char_sha() -> None:
     assert command_priorities(cmds) == [expected]
 
 
-def test_app_commands_with_release_zip(tmp_path) -> None:
-    version = "26.3.0"
-    # construct a source path matching release zip pattern
-    source_path = tmp_path / f"release_{version}.zip"
-    # no need to create the file on disk; path string is enough
-    source = str(source_path)
-    cmds, ver = get_update_app_commands(
-        branch=None,
-        repo="org/repo",
-        source=source,
-        version=None,
-        defer_web_restart=True,
-    )
-    assert ver == version
-    tmp_dir = tempfile.gettempdir()
-    tmp_rls_dir = f"{tmp_dir}/release_{version}"
-    # verify expected sequence of commands and their priorities
-    expected = [
-        (verify_release_archive_command(source, version), -99.5),
-        (["sudo", "rm", "-rf", tmp_rls_dir], -99),
-        (["unzip", "-o", source, "-d", tmp_rls_dir], 0),
-        (["unzip", "-o", f"{tmp_rls_dir}/wheels_{version}.zip", "-d", f"{tmp_rls_dir}/wheels"], 1),
-        (["sudo", "bash", f"{tmp_rls_dir}/pre_update.sh"], 2),
-        (["sudo", "bash", f"{tmp_rls_dir}/update.sh"], 4),
-        (["sudo", "bash", f"{tmp_rls_dir}/post_update.sh"], 20),
-        (["sudo", "rm", "-rf", tmp_rls_dir], 98),
-        (
-            [
-                "/opt/pioreactor/venv/bin/pip",
-                "install",
-                "--no-index",
-                f"--find-links={tmp_rls_dir}/wheels/",
-                f"{tmp_rls_dir}/pioreactor-{version}-py3-none-any.whl[leader_worker]",
-            ],
-            3,
-        ),
-        (
-            [
-                "sudo",
-                "sqlite3",
-                config_module.config.get("storage", "database"),
-                f".read {tmp_rls_dir}/update.sql",
-            ],
-            10,
-        ),
-    ]
-    assert command_priorities(cmds) == expected
-    assert cmds[-1][2] is True
-
-
 def test_app_commands_with_release_zip_with_spaces_in_path(tmp_path) -> None:
     version = "26.3.0"
     source = str(tmp_path / "release bundles" / f"release_{version}.zip")
@@ -442,6 +392,13 @@ def mock_get(_url: str, **_kwargs) -> Response:
             ],
             3,
         ),
+        (
+            [
+                "/opt/pioreactor/venv/bin/pio",
+                "repair",
+            ],
+            99,
+        ),
         (
             [
                 "sudo",
@@ -451,6 +408,15 @@ def mock_get(_url: str, **_kwargs) -> Response:
             ],
             10,
         ),
+        (
+            [
+                "sudo",
+                "sqlite3",
+                config_module.config.get("storage", "database"),
+                "PRAGMA optimize = 0x10002",
+            ],
+            11,
+        ),
         (["sudo", "rm", "-f", archive_location], 97),
     ]
     sqlite_update_command = next(command for command in cmds if command[0][:2] == ["sudo", "sqlite3"])