Separation between the camera component and data provider#289
Open
elad-bar wants to merge 1 commit into
Open
Conversation
elad-bar
commented
May 24, 2022
- Add vacuum manager to handle all the logic
- Camera component will use the latest state of the vacuum manager
- Map status to log messages - every time status is being changed, it will be logged accordingly, no need to call logger
- Map device to handlers instead of IF statement
Owner
|
It looks quite nice. I thought about using built-in coordinator though: |
Author
|
I wanted it to be simple as possible so didn't add new elements just separation and cleanup, but correct, next step is to wrap it as coordinator |
Owner
|
That's an easy change :) I will take a look at it 👍 thank you! |
Author
|
@PiotrMachowski any updates about that PR? thanks |
Owner
|
@elad-bar I plan to make a lot of maintenance on all my repos soon, sorry for long wait, I have a lot of other repos to maintain |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.