art(review): local review app -- persistent verdicts + notes, multi-session (serve_review.py)#706
Merged
Merged
Conversation
…ession (serve_review.py)
Adds tools/art_review/serve_review.py: a stdlib-only (http.server, no deps) local
web app that reviews ALL P(Doom)1 art in one place -- pixellab art_source/ AND the
gpt-image art_generated/ tree (game_icons, ui_icons, hero_banners,
screen_backgrounds, terminal_textures, + any new category dirs).
Per asset: clickable keep/maybe/reroll verdict, free-text note, comma tags, on a
checkered alpha backdrop, grouped by category with a sticky section nav and
keyboard nav (arrows / K / M / R / N). Every edit POSTs to /api/state and
AUTO-PERSISTS to tools/art_review/review_state.json on disk (not localStorage), so
a review survives across sittings and is a clean pipeline input:
{ asset_id: { verdict, note, tags, updated_at } }
asset_id is pipeline-friendly: gen:<category>:<base_id>:<variant> / px:<relpath>.
PNGs stream live from disk via /img?p=<relpath> (path-sandboxed to art-root, png
only) -- the 1.1 GB gitignored art_generated/ tree is never copied or committed.
Closes the "build.py doesn't read art_generated" glue gap in ASSET_PIPELINE.md.
review_state.json is gitignored (per-reviewer local state).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Turns the good art-review UX into a stateful, multi-session local app that covers all the art in one place -- the pixellab
art_source/track and the gpt-imageart_generated/track (game_icons,ui_icons,hero_banners,screen_backgrounds,terminal_textures, plus any new category dirs). Closes the "build.pydoesn't readart_generated/" glue gap flagged indocs/art/ASSET_PIPELINE.md.Adds one file:
tools/art_review/serve_review.py(Python stdlib only --http.server, no Flask/deps).Why this instead of a static HTML
The static
build.py->style_review.htmltool only saw the pixellab sweep and persisted to browser localStorage (fragile across sittings). This is a real local app you can CI/pipeline: verdicts + notes persist to a real file on disk.How to run
Run it from the checkout that has
art_generated/(the main checkout). It auto-opens a browser;--no-browserto skip.What you get
K/M/Rstamp verdicts,Njumps to the note./api/stateand is written totools/art_review/review_state.jsonon disk (debounced for typing). Reload any time, across sessions -- your review is still there.The pipeline contract
review_state.jsonis shaped for promote/reroll tooling to consume:{ "gen:game_icons:icon_doom:v2": { "verdict": "keep", "note": "love the grille", "tags": ["hero", "doom"], "updated_at": "2026-07-19T10:11:12.345678+00:00" } }asset_idis stable + pipeline-friendly:gen:<category>:<base_id>:<variant>for generated art (maps to manifest id + variant),px:<relpath>for pixellab. It's gitignored (per-reviewer local state).No copies, no bloat
PNGs stream live from disk via
/img?p=<relpath>(path-sandboxed to the art-root,.pngonly). The 1.1 GB gitignoredart_generated/tree is never copied or committed. One representative size per asset-variant (prefers 512px).Verification
Smoke-tested end to end against the main checkout's real art:
GET /-> 200, 909 cells across 25 sections (518 generated + 391 pixellab).GET /img?...-> 200image/png; path traversal -> 403; non-png -> 404.review_state.json; reload re-embeds state (multi-session confirmed); toggling a verdict off and clearing note/tags prunes the empty entry.py_compileclean; pre-commit (black/isort/ruff, ASCII enforce) green.Deferred (follow-up)
Verdict/tag filtering (show only un-reviewed / keep / reroll), side-by-side variant compare widget, and wiring
review_state.jsonintopromote_assets.py/ a reroll generator.Does NOT modify
build.py(still the pixellab static-export tool) or commit any PNG /style_review.html/review_state.json.🤖 Generated with Claude Code