Allow parameters to be passed to the created windows#6
Open
HtheChemist wants to merge 3 commits intoPipe-Runner-Lab:masterfrom
Open
Allow parameters to be passed to the created windows#6HtheChemist wants to merge 3 commits intoPipe-Runner-Lab:masterfrom
HtheChemist wants to merge 3 commits intoPipe-Runner-Lab:masterfrom
Conversation
Allow parameter to be passed to a new windows. If the registered component is registered the old way, it simply use it as it. If it is registered as an object with a "url" and a "extra" key it will pass the "extra" as a query which will allow the loadBalancer.job to be more dynamic. Usefull if you want to instance multiple process of the same script.
Collaborator
|
@HtheChemist Sorry for the late response. The code looks great. I was considering creating a new dev branch and a master branch. We can make changes in the dev branch and make release cycles from the master branch. Does that sound good to you? |
Author
|
I don't have any objection, if the project get bigger it will be easier to manage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When registering the path, if you register with an object with an url and extra key it will pass a query with the createHiddenWindow function, else it will act as normal.