New Components - eventdock#21128
Open
kidsil wants to merge 3 commits into
Open
Conversation
Reliable webhook source + reliable HTTP forward action.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
dannyroosevelt
moved this to Ready for PR Review
in Component (Source and Action) Backlog
Collaborator
|
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified. |
Collaborator
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR adds EventDock integration for reliable webhook delivery: an EventDock app client, SSRF-safe destination validation, shared webhook lifecycle utilities, a reliable HTTP forward action, a reliable webhook source, and documentation. ChangesEventDock Webhook Reliability Integration
🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@components/eventdock/actions/reliable-http-forward/reliable-http-forward.mjs`:
- Around line 22-32: Update the prop description strings for destinationUrl and
payload in reliable-http-forward.mjs to include concrete inline examples for AI
agents: for destinationUrl (property name destinationUrl) append a sample URL
such as "e.g. https://api.example.com/webhook", and for payload (property name
payload) append a small JSON example like 'e.g. { "event": "user.created", "id":
123 }'; keep the descriptions otherwise unchanged and ensure the examples are
part of the description string values so they are available to parsers and
agents.
- Around line 107-127: The app methods eventdock.listEndpoints and
eventdock.createEndpoint are called without the run $ context in
findEndpointForDestination and ensureEndpoint; update these calls to pass the $
from the action run (i.e., call this.eventdock.listEndpoints({ $ }) and
this.eventdock.createEndpoint({ $, ... })) so request logging and error
propagation work correctly, and ensure the run({ $ }) parameter is threaded into
any callers of findEndpointForDestination/ensureEndpoint if not already.
In `@components/eventdock/README.md`:
- Around line 40-49: The "Local development & tests" section references
non-monorepo paths (ed-pipedream/, tests/register-stubs.mjs,
tests/components.test.mjs) which confuses Pipedream monorepo contributors;
update the README's "Local development & tests" paragraph (the header and the
code block) to either remove the section if those tests do not exist here, or
change it to a clear note stating this workflow is for the standalone EventDock
upstream repo only (e.g., prefix with "Upstream EventDock development:" and
explain these paths are not valid inside the Pipedream monorepo), or
alternatively replace the example commands/paths with the correct Pipedream
monorepo equivalents if such tests exist—edit the Local development & tests
section accordingly to reflect the chosen option.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 932f7be0-a339-4ee0-b709-52ca4d897830
📒 Files selected for processing (9)
components/eventdock/README.mdcomponents/eventdock/actions/reliable-http-forward/README.mdcomponents/eventdock/actions/reliable-http-forward/reliable-http-forward.mjscomponents/eventdock/common/common-webhook.mjscomponents/eventdock/common/ssrf.mjscomponents/eventdock/eventdock.app.mjscomponents/eventdock/package.jsoncomponents/eventdock/sources/reliable-webhook/README.mdcomponents/eventdock/sources/reliable-webhook/reliable-webhook.mjs
Author
|
Thanks for the review! Addressed the three CodeRabbit notes:
|
Contributor
|
Hi @kidsil, thank you for your contribution! The |
Author
|
Hi @ashwins01 — thanks for the pointer! We've submitted the EventDock app request to integrations@pipedream.com as asked (from asaf@eventdock.app), including auth details (API-key Bearer), a credential-validation endpoint, docs, and logo links. Happy to provide test credentials or anything else the integrations team needs. Looking forward to the review once the app integration is in place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Components - eventdock
Adds the EventDock app with a source and an action for reliable webhook delivery.
Uses EventDock API key auth (masked). No telemetry. Lifecycle creates/reuses and cleans up endpoints. EventDock free tier: 5,000 events/mo at https://eventdock.app.
Summary by CodeRabbit
New Features
Documentation