fix(vapi): add cursor-based pagination to propDefinitions#21135
Open
favzqn wants to merge 1 commit into
Open
Conversation
The phoneNumberId, assistantId, and squadId async options previously fetched only a single page. Add createdAtLt cursor pagination using the prevContext pattern so accounts with >1000 resources can load more. Closes PipedreamHQ#21085
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
dannyroosevelt
moved this to Ready for PR Review
in Component (Source and Action) Backlog
ashwins01
requested changes
Jun 15, 2026
Contributor
There was a problem hiding this comment.
Hi @favzqn, thank you for you contribution! Since there are changes in the vapi.app.mjs file, the corresponding actions need their versions to be updated for them to be reviewed and tested properly. Can you resolve conflicts and update the package versions and do a round of testing for the list-* actions ?
Sharing our contribution guidelines for your reference: https://pipedream.com/docs/components/contributing/guidelines
Also, since the return shape has changed, the caller sites need to be modified to utilise the changed options return change aswell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21085.
The three propDefinitions (phoneNumberId, assistantId, squadId) previously fetched only a single page of results. This adds
createdAtLtcursor pagination using theprevContextpattern so accounts with >1000 resources can load more results in the dropdown.Changes
vapi.app.mjs: Eachasync options()now acceptsprevContext, passescreatedAtLtas a query param for the next page, and returns{ options, context }to support load-morepackage.json: Version bump0.3.0->0.3.1Validation
pnpm eslint components/vapi— passes cleannode --check— passesnode scripts/build-components.mjs components/vapi— passes