Skip to content

[21131] refactor(snowflake): replace async-options with standalone actions#21186

Open
ashwins01 wants to merge 16 commits into
masterfrom
issue-21131-snowflake
Open

[21131] refactor(snowflake): replace async-options with standalone actions#21186
ashwins01 wants to merge 16 commits into
masterfrom
issue-21131-snowflake

Conversation

@ashwins01

@ashwins01 ashwins01 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR is a followup for #21161 to replace async-options with standalone actions in the base snowflake connector

Checklist

Please check the following items before your PR can be reviewed:

Versioning

  • All components updated in this PR had their version updated (0.0.1 for new ones)
  • The app updated in this PR had its package.json's version updated

New app

If this is a new app, please submit an app integration request - the PR will only be reviewed after the app is integrated.

  • The app updated in this PR is already integrated

CodeRabbit review

After the PR is opened, and if new changes are pushed, CodeRabbit will automatically review it. Do not 'mark as resolved' CodeRabbit's comments, but reply to them instead, whether you agree (and update the PR accordingly) or disagree.

  • I have addressed or acknowledged all of CodeRabbit's review comments

Summary by CodeRabbit

  • New Features

    • New action to list available schemas within a Snowflake database
    • New action to list available tables within a selected schema
    • New action to list available columns within a selected table
  • Enhancements

    • Insert row and insert multiple rows operations now use fully qualified table names (database.schema.table format)

@vercel

vercel Bot commented Jun 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
pipedream-docs-redirect-do-not-edit Ignored Ignored Jun 22, 2026 6:27am

Request Review

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: ae243908-3397-47e9-9425-95bb8f8bd8af

📥 Commits

Reviewing files that changed from the base of the PR and between 607e2c2 and 79c44da.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (6)
  • components/snowflake/actions/insert-multiple-rows/insert-multiple-rows.mjs
  • components/snowflake/actions/insert-row/insert-row.mjs
  • components/snowflake/actions/list-column-options/list-column-options.mjs
  • components/snowflake/actions/list-schema-options/list-schema-options.mjs
  • components/snowflake/actions/list-table-options/list-table-options.mjs
  • components/snowflake/package.json

📝 Walkthrough

Walkthrough

Three new read-only Snowflake actions are added to list schema, table, and column name options. The existing insert-row and insert-multiple-rows actions are updated to construct and use fully-qualified table names (database.schema.tableName) in their additionalProps, run calls, and $summary messages. The package version is bumped to 0.15.0.

Changes

Snowflake Actions: Fully-Qualified Table Names and List-Options Helpers

Layer / File(s) Summary
New list-schema, list-table, and list-column-options actions
components/snowflake/actions/list-schema-options/list-schema-options.mjs, components/snowflake/actions/list-table-options/list-table-options.mjs, components/snowflake/actions/list-column-options/list-column-options.mjs
Adds three new read-only action modules. Each accepts scoping props (database, schema, tableName as applicable), calls the matching snowflake app method (listSchemas, listTables, listFieldsForTable), exports a count-based $summary, and returns an array of name strings.
Insert actions updated to fully-qualified table names
components/snowflake/actions/insert-row/insert-row.mjs, components/snowflake/actions/insert-multiple-rows/insert-multiple-rows.mjs, components/snowflake/package.json
Both insert actions now compute ${database}.${schema}.${tableName} at runtime and pass that string to insertRow/insertRows and $summary output. insert-row also uses the qualified name in additionalProps for field listing. Versions bumped to 1.2.0, 0.2.0, and package 0.15.0 respectively.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • GTFalcao
  • vetrivigneshwaran
  • michelle0927
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: replacing async-options with standalone actions in the Snowflake connector.
Description check ✅ Passed The PR description covers the purpose (followup to #21161), includes a complete checklist with versioning and CodeRabbit items addressed, and references relevant context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-21131-snowflake

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pipedream-component-development

Copy link
Copy Markdown
Collaborator

Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.

@pipedream-component-development

Copy link
Copy Markdown
Collaborator

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

@s0s0physm

Copy link
Copy Markdown
Collaborator

@ashwins01 - pause merging please

@s0s0physm

Copy link
Copy Markdown
Collaborator

@ashwins01 - pause merging please

Base automatically changed from issue-21131-snowflake-oauth to master June 18, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ACTION] Snowflake (Oauth version)

3 participants