Add Cancel Fulfillment action for Shopify#21189
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified. |
|
Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughA new ChangesShopify Cancel Fulfillment Action
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@components/shopify/actions/fulfillment-cancel/fulfillment-cancel.mjs`:
- Line 7: The app package version in components/shopify/package.json must be
bumped to accommodate the new component starting at version 0.0.1. Update the
version field in the shopify package.json from 0.9.0 to 0.9.1 (bump the patch
version by at least one increment) to align with the new component version being
introduced in this PR.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 308e6c50-efda-4407-91a8-7d668d2fee74
📒 Files selected for processing (3)
components/shopify/actions/fulfillment-cancel/fulfillment-cancel.mjscomponents/shopify/common/mutations.mjscomponents/shopify/shopify.app.mjs
Adds a new "Cancel Fulfillment" action for the Shopify component, implementing the
fulfillmentCancelGraphQL mutation.Closes part of #21188 (fulfillmentCancel)
Changes
FULFILLMENT_CANCELmutation tocommon/mutations.mjscancelFulfillmentmethod toshopify.app.mjsfulfillment-cancelthat lets users cancel an existing fulfillment by IDTesting
I was unable to test against a live Shopify store, as I don't currently have API credentials for one. The mutation syntax has been validated against the GraphQL spec, and the code follows the existing patterns used in
get-fulfillment.mjsanddelete-webhook. Happy to address any issues found in review.API documentation reference: https://shopify.dev/docs/api/admin-graphql/latest/mutations/fulfillmentCancel
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Enhancements
Chores