(optional) add metadata to get/put steps#19
Open
aliculPix4D wants to merge 1 commit into
Open
Conversation
aliculPix4D
requested review from
SpectreVert,
iAmoric,
marco-m-pix4d and
odormond
and removed request for
a team
July 1, 2026 09:25
aliculPix4D
commented
Jul 1, 2026
aliculPix4D
commented
Jul 1, 2026
aliculPix4D
force-pushed
the
pci-4876-fix-versioning
branch
from
July 1, 2026 11:20
7355e2f to
663996a
Compare
aliculPix4D
force-pushed
the
pci-4876-add-metadata
branch
4 times, most recently
from
July 1, 2026 14:00
4dde374 to
fd45d19
Compare
aliculPix4D
force-pushed
the
pci-4876-add-metadata
branch
from
July 2, 2026 09:03
fd45d19 to
06aa891
Compare
odormond
reviewed
Jul 6, 2026
odormond
left a comment
odormond
left a comment
There was a problem hiding this comment.
Good idea but I would not include the region nor the files list. I don't think the former is really helpful and the later could easily turn the output into a mess if there is a lot of files (which I expect for people uploading full set of generated doc).
Member
|
weird, I thought I had commented on this PR already. I notice now on the screenshots that we cannot see the region, is that expected? I agree though, the region is probably not helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(optional) add metadata to get/put steps
WARNING: AI-generated... If you wish I can drop this PR, its just to show what we can do... My main question here is: do we want to?
Feel free to inspect the feature pipeline to see how it looks.
The only thing that worries me is: what if the number of files is very very large.