bug fixes

Author: PixelCode01

.github/pull_request_template.md

@@ -146,18 +146,6 @@ Related to #
 
 
 
-## For Maintainers
-
-<!-- Maintainers: Check these before merging -->
-
-- [ ] Code review completed
-- [ ] Risk levels verified
-- [ ] Testing evidence provided and adequate
-- [ ] Documentation updated
-- [ ] No conflicts with existing data
-- [ ] JSON structure validated
-- [ ] Ready to merge
-
 ---
 
 **Note for contributors:** Please fill out all relevant sections. Incomplete PRs may be delayed or closed. If you're using the contribution tool (`python contribute.py`), it automatically formats everything correctly!

.github/workflows/auto-generate-files.yml

@@ -0,0 +1,53 @@
+name: Auto-Generate Brand Files
+
+on:
+  push:
+    paths:
+      - 'packages_registry.json'
+    branches:
+      - main
+  pull_request:
+    paths:
+      - 'packages_registry.json'
+
+jobs:
+  generate:
+    runs-on: ubuntu-latest
+    
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v3
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+      
+      - name: Set up Python
+        uses: actions/setup-python@v4
+        with:
+          python-version: '3.11'
+      
+      - name: Generate brand files
+        run: |
+          python scripts/generate_brand_files.py --all
+      
+      - name: Check for changes
+        id: git-check
+        run: |
+          git diff --exit-code || echo "changes=true" >> $GITHUB_OUTPUT
+      
+      - name: Commit and push changes
+        if: steps.git-check.outputs.changes == 'true' && github.event_name == 'push'
+        run: |
+          git config user.name "github-actions[bot]"
+          git config user.email "github-actions[bot]@users.noreply.github.com"
+          git add .
+          git commit -m "Auto-generate brand files from registry [skip ci]"
+          git push
+      
+      - name: Commit changes to PR
+        if: steps.git-check.outputs.changes == 'true' && github.event_name == 'pull_request'
+        run: |
+          git config user.name "github-actions[bot]"
+          git config user.email "github-actions[bot]@users.noreply.github.com"
+          git add .
+          git commit -m "Auto-generate brand files from registry"
+          git push origin HEAD:${{ github.head_ref }}

Asus/asus_remover.py

@@ -7,10 +7,8 @@
 
 
 class AsusRemover(BloatwareRemover):
-    """Asus-specific bloatware remover"""
-
-    def __init__(self, test_mode: bool = False):
-        super().__init__('Asus', 'Asus/asus_config.json', test_mode)
+    def __init__(self, test_mode: bool = False, use_registry: bool = True):
+        super().__init__('Asus', 'Asus/asus_config.json', test_mode, use_registry=use_registry)
 
     def _get_default_packages(self):
         return {

CONTRIBUTING.md

@@ -24,6 +24,82 @@ python contribute.py
 
 This interactive tool will guide you through adding new packages to the registry.
 
+### What's New?
+
+#### Before (Old System)
+To add a new package, you needed to:
+1. Edit the brand's Python file (`Samsung/samsung_remover.py`)
+2. Edit the brand's Shell script (`Samsung/samsung_remover.sh`)
+3. Edit the brand's Markdown file (`Samsung/samsung-bloatware-list.md`)
+4. Ensure consistency across all three files
+5. Know Python, Shell, and Markdown syntax
+
+#### After (New System)
+Now you can:
+1. Run `python contribute.py` (interactive tool)
+2. OR edit `packages_registry.json` directly
+3. That's it! One source of truth for all packages
+
+### Contributing Methods
+
+#### Method 1: Interactive Tool (Recommended)
+
+```bash
+# Run the contribution tool
+python contribute.py
+```
+
+The tool will guide you through:
+- Selecting brand and category
+- Entering package information
+- Validating risk levels
+- Saving to the registry
+
+#### Method 2: Command Line
+
+```bash
+# Add a package directly
+python contribute.py add \
+  --brand samsung \
+  --category bixby \
+  --package com.samsung.android.bixby.test \
+  --description "Bixby Test Service" \
+  --risk safe
+
+# Search for packages
+python contribute.py search --query "bixby"
+
+# Remove a package
+python contribute.py remove --brand samsung --package com.example.package
+```
+
+#### Method 3: Manual JSON Editing
+
+Edit `packages_registry.json` directly:
+
+```json
+{
+  "brands": {
+    "samsung": {
+      "name": "Samsung",
+      "categories": {
+        "bixby": {
+          "name": "Bixby Services",
+          "description": "Samsung's virtual assistant",
+          "packages": [
+            {
+              "name": "com.samsung.android.bixby.agent",
+              "description": "Bixby Voice Assistant",
+              "risk": "safe"
+            }
+          ]
+        }
+      }
+    }
+  }
+}
+```
+
 ## How to Identify Bloatware Packages
 
 ### Step 1: List All Packages on Your Device
@@ -265,6 +341,101 @@ Use the **"New Package Entry"** issue template
 
 Use the **"Update Risk Level"** issue template if you have evidence that a package's risk level should change
 
+## API for Developers
+
+If you're integrating with the registry programmatically:
+
+```python
+from core.package_registry import PackageRegistry
+
+# Initialize registry
+registry = PackageRegistry()
+
+# Get all brands
+brands = registry.get_brands()
+
+# Get packages for a brand
+packages = registry.get_packages_for_brand('samsung')
+
+# Get specific package info
+info = registry.get_package_info('samsung', 'com.samsung.android.bixby.agent')
+
+# Add a package
+registry.add_package('samsung', 'bixby', {
+    'name': 'com.test.app',
+    'description': 'Test App',
+    'risk': 'safe'
+})
+
+# Save changes
+registry.save_registry()
+```
+
+## Troubleshooting
+
+### "Package already exists"
+```bash
+python contribute.py search --query "package-name"
+# Check if it's already in the registry
+```
+
+### "Invalid JSON"
+```bash
+# Validate your JSON
+python -m json.tool packages_registry.json
+```
+
+### "Permission denied"
+```bash
+# Make contribute.py executable
+chmod +x contribute.py
+```
+
+## Best Practices
+
+1. **Always test before adding**
+   - Use real device or test mode
+   - Verify functionality
+   - Test recovery
+
+2. **Use descriptive information**
+   - Clear package descriptions
+   - Accurate risk levels
+   - Proper categorization
+
+3. **Document your testing**
+   - Device model and Android version
+   - Features tested
+   - Issues encountered
+
+4. **Follow PR template**
+   - Complete all sections
+   - Provide evidence
+   - Link related issues
+
+## FAQ
+
+**Q: Do I need to know Python?**
+A: No! Use the interactive tool or edit JSON directly.
+
+**Q: Can I still edit the .py files?**
+A: Yes, but it's not recommended. Use the registry instead.
+
+**Q: Will old .md files be updated?**
+A: They may be auto-generated from the registry in the future.
+
+**Q: How do I add a new brand?**
+A: Use `python contribute.py` and select "Add a new brand"
+
+**Q: What if I make a mistake?**
+A: Git version control keeps everything safe. Just submit a correction PR!
+
+## Support
+
+- Read this contribution guide thoroughly
+- Start a [Discussion](https://github.com/PixelCode01/UIBloatwareRegistry/discussions)
+- Report an [Issue](https://github.com/PixelCode01/UIBloatwareRegistry/issues)
+
 ## License
 
 By contributing to the UIBloatwareRegistry repository, you agree that your contributions will be licensed under the [MIT License](https://opensource.org/licenses/MIT).
@@ -273,5 +444,5 @@ By contributing to the UIBloatwareRegistry repository, you agree that your contr
 
 We appreciate your contributions and look forward to building a valuable resource for managing Android bloatware together!
 
-For more detailed information, see [CONTRIBUTION_GUIDE.md](CONTRIBUTION_GUIDE.md).
+**Happy Contributing!**