Skip to content

tablist gui Component#2712

Closed
Wunka wants to merge 1 commit intoPixelGuys:masterfrom
Wunka:tablist-comp
Closed

tablist gui Component#2712
Wunka wants to merge 1 commit intoPixelGuys:masterfrom
Wunka:tablist-comp

Conversation

@Wunka
Copy link
Copy Markdown
Contributor

@Wunka Wunka commented Mar 10, 2026

This adds add Tablist gui Component
After seeing #2705 I thought that the tabs should have an abstraction but to not make #2705 too big @H41ogen said I should seperate this into this PR.

Tested can this be with my tablist branch https://github.com/Wunka/Cubyz/tree/tablist with which I first wanted to make a PR onto #2705

This component only handels the rendering, buttonPressing etc of the tabs themself. A header or other things to control which tab is open is for now in the hands of the component user

@H41ogen
Copy link
Copy Markdown
Contributor

H41ogen commented Mar 10, 2026

You should add an image showing it off

@BoySanic BoySanic moved this to High Priority in PRs to review Mar 11, 2026
@BoySanic
Copy link
Copy Markdown
Contributor

I put it in high priority because it's blocking #2705

@Wunka
Copy link
Copy Markdown
Contributor Author

Wunka commented Mar 11, 2026

Just a heads up. When I am back at my pc I will remove setValues() as its logic is replaced by finish() I just forgot to delete it. This does not change anything else so this PR can still be reviewed.

Copy link
Copy Markdown
Member

@IntegratedQuantum IntegratedQuantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted in #2705, I would prefer a collapsible section. Please close, or provide other reasons for why we should have it.

@IntegratedQuantum IntegratedQuantum moved this from High Priority to In review in PRs to review Mar 17, 2026
@Wunka Wunka closed this Mar 17, 2026
@Wunka
Copy link
Copy Markdown
Contributor Author

Wunka commented Mar 17, 2026

I currently cannot think about another place where this could be useful. so closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants