Skip to content

Whitelisting1#2801

Draft
Mabeeck wants to merge 5 commits intoPixelGuys:masterfrom
Mabeeck:whitelisting1
Draft

Whitelisting1#2801
Mabeeck wants to merge 5 commits intoPixelGuys:masterfrom
Mabeeck:whitelisting1

Conversation

@Mabeeck
Copy link
Copy Markdown

@Mabeeck Mabeeck commented Apr 2, 2026

Pull request for whitelisting functionality on the server side.
No commands will be included in this PR.
Does some progress with #2566.

I might still need some help to handle rejecting the connection better.

  • Fix: [error]: Encountered error while opening world: DisconnectedByServer on client, when connection is rejected
  • Get rid of [info]: Disconnected (x2) in server logs when rejecting a connection
  • Prevent player file creation for rejected connection requests

Copy link
Copy Markdown
Contributor

@Wunka Wunka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The struct is probably from the times when it had a few more fields and this is still a draft so don't take my requested changes to hard.

I have not yet tested your code (it still a draft I don't require it to already work perfectly)

Comment thread src/network/protocols.zig Outdated
Comment thread src/server/whitelist.zig Outdated
Comment thread src/server/world.zig Outdated
Comment thread src/server/world.zig Outdated
Comment thread src/server/world.zig Outdated
Comment thread src/network.zig Outdated
@Wunka
Copy link
Copy Markdown
Contributor

Wunka commented Apr 3, 2026

Get rid of [info]: Disconnected (x2) in server logs when rejecting a connection

I think this happens not only in your PR. So if you can get rid of it 🎉 but don't focus on it

@Wunka Wunka moved this to WIP/not ready for review in PRs to review Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: WIP/not ready for review

Development

Successfully merging this pull request may close these issues.

2 participants