Add default implementation to some of the modifiers virtual functions#2812
Merged
IntegratedQuantum merged 5 commits intoPixelGuys:masterfrom Apr 11, 2026
Merged
Conversation
Argmaster
commented
Apr 4, 2026
Member
|
Please fix merge conflicts |
IntegratedQuantum
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am looking to add a
callbackhook (possibly even few in long term) to the modifier vtable and it gets impractical to define all of them every time, so in this pull request I am proposing to add default implementations for some of the callbacks so we need less boilerplate:changeToolParameterschangeBlockDamage