Entity model node system by RanPix · Pull Request #2824 · PixelGuys/Cubyz

RanPix · 2026-04-05T14:53:45Z

requires #2762 and #2682
fixes #2419
progress towards #87, #2734 and #726

so far only supports 20 nodes per model

20260405-1250-04.3932246.mp4

Co-authored-by: careeoki <122191047+careeoki@users.noreply.github.com>

also renamed entity.zig -> clientEntity.zig to make it easier to distingues it from the already existing Entity.zig in server/

… into ECS_United7

…into ECS_United7

…ityLoadsComponents

…eLoadingFromAsset

… into ECS_United7

…into ECS_United7

… into ECS_Protocol

…o joints

RanPix · 2026-05-01T09:35:48Z

ready for review

IntegratedQuantum · 2026-05-04T19:15:03Z

 	.defaultTexture = "cubyz:cubert",
 	.height = 2,
-	.coordinateSystem = .right_handed_z_up,
+	.isPlayerModel = true,


unintended change

IntegratedQuantum · 2026-05-04T19:15:10Z

 	.model = "cubyz:snale",
 	.defaultTexture = "cubyz:snale",
 	.height = 2,
+	.isPlayerModel = true,


unintended change

IntegratedQuantum · 2026-05-04T19:16:01Z

Could you explain what changed here? I see no difference

IntegratedQuantum · 2026-05-04T19:16:36Z

 	normal = inNormal;

-	vec4 mvPos = viewMatrix*vec4(inPos, 1);
+	vec4 mvPos = viewMatrix * nodeMatrices[inNodeID] * vec4(inPos, 1);


Please follow the formatting style

Suggested change

vec4 mvPos = viewMatrix * nodeMatrices[inNodeID] * vec4(inPos, 1);

vec4 mvPos = viewMatrix*nodeMatrices[inNodeID]*vec4(inPos, 1);

IntegratedQuantum · 2026-05-04T19:18:43Z

+		const head = model.nodeReverse.get("Head");
+		if (model.nodeReverse.get("Eyestalks")) |eyestalksId| {
+			const stalkRot = self.rot[0]*0.25;
+			const headRot = self.rot[0]*0.75;


Instead of hardcoding it here, could this information be stored in the model somehow? Does it allow to add named variables to the nodes, so you could add to each node how much head rotation it gets?

IntegratedQuantum · 2026-05-04T19:32:45Z

 		pos: [3]f32,
 		normal: [3]f32,
 		uv: [2]f32,
+		nodeID: c_uint,


Suggested change

nodeID: c_uint,

nodeId: c_uint,

IntegratedQuantum · 2026-05-04T19:32:56Z

+			.{
+				.location = 3,
+				.format = c.VK_FORMAT_R32_UINT,
+				.offset = @offsetOf(@This(), "nodeID"),


Suggested change

.offset = @offsetOf(@This(), "nodeID"),

.offset = @offsetOf(@This(), "nodeId"),

IntegratedQuantum · 2026-05-04T19:37:03Z

 }

+// copied from zmath library (MIT Liscence) : https://github.com/zig-gamedev/zmath/blob/9f7beb0753bd5cf885285dda8b00361c87c5b6b3/src/root.zig#L3570
+fn sincos32(v: f32) [2]f32 {


Please just use @sin and @cos or if you really think we need it, you can use sincos from math.h

I'd rather not have too much foreign code in here.

IntegratedQuantum · 2026-05-04T19:38:33Z

+}
+
+// copied from zmath library (MIT Liscence) :  https://github.com/zig-gamedev/zmath/blob/9f7beb0753bd5cf885285dda8b00361c87c5b6b3/src/root.zig#L2985
+pub fn quatFromAxisAngle(axis: Vec3f, angle: f32) Vec4f {


Please add a Quat type that contains a vector, so we have at least some type safety.
also add a MARK for it as well.

IntegratedQuantum · 2026-05-04T19:39:29Z

-						vertSlice[v].uv = .{uv[0], 1 - uv[1]};
+				var positionAttr: gltf.cgltf_accessor = undefined;
+				var normalAttr: gltf.cgltf_accessor = undefined;
+				var uvAttr: gltf.cgltf_accessor = undefined;


Could you please make a seperate PR for just the indentation change you did here?
This is just awful to review in github.

tillpp

I appreciate the effort, but request a change:

tillpp · 2026-05-04T20:38:59Z

+			modelComp.matrices[headId] = modelComp.nodes[headId].getHierarchyMatrix(modelComp.nodes);
+		} else if (head) |headId| {
+			modelComp.nodes[headId].rot = vec.quatFromAxisAngle(Vec3f{1, 0, 0}, self.rot[0]);
+			modelComp.matrices[headId] = modelComp.nodes[headId].getHierarchyMatrix(modelComp.nodes);


Is it possible to move this code somewhere else?
I would prefer the Entity.zig be component agnostic

RanPix and others added 30 commits November 6, 2025 17:45

wip importing

21aacfa

silly indices parsing

8284574

almost load a model

088cd06

Assets.

020422b

Co-authored-by: careeoki <122191047+careeoki@users.noreply.github.com>

removed material

37adbae

added Templates for entity component and entity systems

a8fba76

also renamed entity.zig -> clientEntity.zig to make it easier to distingues it from the already existing Entity.zig in server/

Entity registers and unregisters from entityComponents,

61e9795

have general Base64 classes and functions

acc5c1b

EntityComponentUpdate Protocol

9a3e70e

load EntityTypes from Assets

bafca57

made player a function

93bd094

removed loadWorldAsset function

5fbf9ba

Merge remote-tracking branch 'origin/ECS_PlayerIsAFunction'

c2e7539

Merge remote-tracking branch 'origin/ECS_ServerEntityLoadsComponents'…

8f3bd44

… into ECS_United7

Merge remote-tracking branch 'origin/ECS_EntityTypeLoadingFromAsset' …

0a32373

…into ECS_United7

Merge remote-tracking branch 'origin/ECS_Protocol' into ECS_United7

0fe9857

Merge remote-tracking branch 'origin/ECS_Template' into ECS_United7

60254d9

Merge remote-tracking branch 'origin/ECS_Template' into ECS_ServerEnt…

a912431

…ityLoadsComponents

Merge remote-tracking branch 'origin/ECS_Template' into ECS_Protocol

9af0011

Merge remote-tracking branch 'origin/ECS_Template' into ECS_EntityTyp…

2dbc78e

…eLoadingFromAsset

removed loadWorldAssets

1e04fa3

Merge remote-tracking branch 'origin/ECS_Protocol' into ECS_United7

ac18860

Merge remote-tracking branch 'origin/ECS_ServerEntityLoadsComponents'…

1b44749

… into ECS_United7

Merge remote-tracking branch 'origin/ECS_EntityTypeLoadingFromAsset' …

baae55c

…into ECS_United7

entityModel

033c645

added entityModelComponent

3932133

temporary Deinits

927849b

Merge remote-tracking branch 'origin/ECS_ServerEntityLoadsComponents'…

c962389

… into ECS_Protocol

fmt

87b048a

Merge remote-tracking branch 'origin/ECS_Protocol' into ECS_United7

82a8004

RanPix and others added 15 commits April 13, 2026 11:34

cleanup

3e7e63d

Merge remote-tracking branch 'Tillpp/ECS_AddEntityModelComponent' int…

084fe12

…o joints

Merge remote-tracking branch 'Tillpp/ECS_AddEntityModelComponent' int…

cb0ae0a

…o joints

preliminary move to ecs8

e6e611f

client.get

89b0172

Merge remote-tracking branch 'Tillpp/ECS_AddEntityModelComponent' int…

303f131

…o joints

Merge remote-tracking branch 'Tillpp/ECS_AddEntityModelComponent' int…

5e27e00

…o joints

cleanup

f550bb4

make @RanPix happy. load models before entityComponents

55a7958

Merge commit '55a79582e612889a0d0c03d7edeebf4e8672c698' into joints

aa139e9

load player later

fd70dc7

fmt

d11f0d4

switch opengl context just for the handshake for a short time

7acbf41

i am an idiot

5f8ed5c

Merge commit '5f8ed5c7aa82c8a127daf44b9c29ba4485c205a4' into joints

fa0cc39

RanPix mentioned this pull request Apr 13, 2026

Third person item display #2902

Draft

RanPix added 3 commits April 30, 2026 20:57

Merge remote-tracking branch 'origin/master' into joints

c486c98

lock network thread to load assets before recieving entity data

659eb21

cleanup

7ff1aa9

RanPix marked this pull request as ready for review May 1, 2026 09:11

RanPix added 3 commits May 1, 2026 11:15

аье

a22b916

fmt2

ab1f092

fmt3

b1dab22

RanPix added 2 commits May 1, 2026 12:06

update cubert model

facacbe

fix cubert

e598e24

Wunka moved this from WIP/not ready for review to High Priority in PRs to review May 4, 2026

IntegratedQuantum requested changes May 4, 2026

View reviewed changes

IntegratedQuantum moved this from High Priority to In review in PRs to review May 4, 2026

tillpp suggested changes May 4, 2026

View reviewed changes

	vec4 mvPos = viewMatrix * nodeMatrices[inNodeID] * vec4(inPos, 1);
	vec4 mvPos = viewMatrixnodeMatrices[inNodeID]vec4(inPos, 1);

	.offset = @offsetOf(@This(), "nodeID"),
	.offset = @offsetOf(@This(), "nodeId"),

Uh oh!

Conversation

RanPix commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RanPix commented May 1, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tillpp left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

RanPix commented Apr 5, 2026 •

edited

Loading