fix(raw): propagate EPIPE after exhausting sendReport retries#555
Open
jelmerdehen wants to merge 1 commit into
Open
fix(raw): propagate EPIPE after exhausting sendReport retries#555jelmerdehen wants to merge 1 commit into
jelmerdehen wants to merge 1 commit into
Conversation
The retry loop in RawDevice::sendReport tolerated up to max_write_tries EPIPE returns, but if every retry returned EPIPE the loop exited silently and the caller believed the report had been delivered. The HID++ layer would then sit waiting for a response that never came, masking a stuck or disconnected device until the io_timeout fires. Track the last errno and throw the same std::system_error after the retry budget is spent, so callers learn the write actually failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The retry loop in
RawDevice::sendReport:tolerates up to
max_write_triesEPIPE returns. If every retry returns EPIPE the loop exits silently and the caller believes the report has been delivered. The HID++ layer then waits for a response that never comes, masking a stuck or disconnected device untilio_timeoutfires.Fix
Track the last
errnoand throw the samestd::system_errorafter the retry budget is spent.Test plan
EPIPEinstead of waiting onio_timeout.