Fix scroll remainder accumulation in AxisGesture#558
Open
klopyrev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug in
AxisGesturewhere the fractional remainder of scroll movements (_axis_remainder) is calculated and saved but never added back to the movement delta of subsequent scroll events.Why this is needed
When a small
axis_multiplier(such as0.1or0.07) is used with high-resolution scrolling, individual scroll events are scaled down to fractional values less than1.0(e.g.,0.8). Because the remainder is never accumulated,floor()truncates all movements to0, making the scroll wheel completely unresponsive (dead) at slow scrolling speeds.By adding
move += _axis_remainder;before calculatingmove_floor, fractional scroll inputs successfully pool together and trigger scroll ticks as expected, allowing users to configure slow, comfortable scroll speeds without losing precision.