Folia Support & Modernize Expansion#22
Conversation
|
I dislike the renaming a lot for multiple reasons:
Downgrading the version makes no sense either. If anything should this be a v3 to indicate a breaking change... Or be a separate project, which I personally recommend over changing a pre-existing expansion that massively. Also, has the Scheduler changes been tested to also be safe on Spigot? PAPI servers Spigot too, even if Paper is better in multiple ways, so making sure that it can still work on non-Folia and non-Paper servers is a must imo. Also, you're using two sets of annotations where only one should be used. Either stick with jspecify or jetbrains annotations, but not both. |
|
I was under the impression that this expansion was no longer maintained, as PlaceholderAPI implemented support for Folia a good bit ago, and this was used as a "modernized" gateway for people simply wanting a more "AIO" replacement and wasn't targeted towards people on the Spigot platform. If you (or the associated author) intend to merge a PR like this, I'd be happy to reconsider this entire PR. In a direct sense, none of the provided changes would actually break Spigot support except for the technicalities of converting from |
|
Hey @Andre601, I went ahead and reverted all logic and applied your tips/suggestions (alongside testing this against Spigot). Let me know if you'd like any other changes, and I'll make them. Hopes this PR sees a merge! |
I'd assume this expansion is inactive; however, this PR is designed for people who continually run into problems with the base Bungee expansion and covers all "known" possible race conditions. This PR also generalizes the placeholder and uses "proxy" instead of "bungee," since "bungee" is a bit specific platform-wise.
E.g. of conversion:
%bungee_total%->%proxy_total%Explanation:
getOnlinePlayersis not thread-safe. Should be wrapped in anArrayList(or similar) to ensure that it's not directly reading from process to mitigate crash (rare but CAN happen)Closes: #18 (Supersedes)
Fixes: #21