Update jax requirement from !=0.7.1,<0.10.0,>=0.6.2 to >=0.6.2,!=0.7.1,<0.11.0 in the jax group across 1 directory#2235
Update jax requirement from !=0.7.1,<0.10.0,>=0.6.2 to >=0.6.2,!=0.7.1,<0.11.0 in the jax group across 1 directory#2235dependabot[bot] wants to merge 12 commits into
Conversation
Memory benchmark result| Test Name | %Δ | Master (MB) | PR (MB) | Δ (MB) | Time PR (s) | Time Master (s) |
| -------------------------------------- | ------------ | ------------------ | ------------------ | ------------ | ------------------ | ------------------ |
test_objective_jac_w7x | 2.64 % | 3.994e+03 | 4.099e+03 | 105.39 | 30.34 | 29.23 |
test_proximal_jac_w7x_with_eq_update | 4.72 % | 6.618e+03 | 6.930e+03 | 312.22 | 148.13 | 150.64 |
test_proximal_freeb_jac | 0.61 % | 1.339e+04 | 1.347e+04 | 81.17 | 81.54 | 80.52 |
test_proximal_freeb_jac_blocked | 1.05 % | 7.724e+03 | 7.805e+03 | 81.28 | 70.39 | 66.96 |
test_proximal_freeb_jac_batched | 1.68 % | 7.601e+03 | 7.728e+03 | 127.71 | 69.38 | 66.35 |
test_proximal_jac_ripple | 4.28 % | 3.466e+03 | 3.614e+03 | 148.42 | 53.84 | 52.53 |
test_proximal_jac_ripple_bounce1d | 4.18 % | 3.794e+03 | 3.952e+03 | 158.43 | 67.00 | 65.99 |
test_eq_solve | 6.60 % | 1.954e+03 | 2.083e+03 | 129.03 | 53.56 | 55.77 |For the memory plots, go to the summary of |
Updates the requirements on [jax](https://github.com/jax-ml/jax) to permit the latest version. Updates `jax` to 0.10.1 - [Release notes](https://github.com/jax-ml/jax/releases) - [Changelog](https://github.com/jax-ml/jax/blob/main/CHANGELOG.md) - [Commits](jax-ml/jax@jax-v0.6.2...jax-v0.10.1) --- updated-dependencies: - dependency-name: jax dependency-version: 0.10.1 dependency-type: direct:production dependency-group: jax ... Signed-off-by: dependabot[bot] <support@github.com>
3d11039 to
a71b715
Compare
|
Should we go back to updating by patch release? |
| xtol=1e-16, | ||
| maxiter=200, | ||
| verbose=3, | ||
| options={"tr_method": "svd"}, |
There was a problem hiding this comment.
Consider explaining this issue in tr_method docs for QR. If there is a chance that the jacobian is singular, then SVD is the more reliable option. If the problem is well-posed otherwise, having a wide bounds can cause this (some of the columns are completely 0).
| benchmark_name | dt(%) | dt(s) | t_new(s) | t_old(s) |
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
test_build_transform_fft_midres | +1.44 +/- 2.78 | +1.24e-02 +/- 2.39e-02 | 8.73e-01 +/- 2.1e-02 | 8.61e-01 +/- 1.2e-02 |
test_build_transform_fft_highres | +1.11 +/- 2.55 | +1.28e-02 +/- 2.95e-02 | 1.17e+00 +/- 2.1e-02 | 1.16e+00 +/- 2.1e-02 |
test_equilibrium_init_lowres | +2.54 +/- 3.29 | +1.59e-01 +/- 2.06e-01 | 6.41e+00 +/- 1.5e-01 | 6.26e+00 +/- 1.4e-01 |
test_objective_compile_atf | -2.17 +/- 3.99 | -1.31e-01 +/- 2.41e-01 | 5.92e+00 +/- 2.3e-01 | 6.05e+00 +/- 8.2e-02 |
test_objective_compute_atf | +2.80 +/- 13.31 | +5.87e-05 +/- 2.79e-04 | 2.15e-03 +/- 1.6e-04 | 2.10e-03 +/- 2.3e-04 |
test_objective_jac_atf | +1.64 +/- 7.51 | +2.46e-02 +/- 1.13e-01 | 1.52e+00 +/- 9.3e-02 | 1.50e+00 +/- 6.3e-02 |
test_perturb_1 | +0.22 +/- 1.68 | +3.33e-02 +/- 2.58e-01 | 1.54e+01 +/- 2.2e-01 | 1.54e+01 +/- 1.3e-01 |
test_proximal_jac_atf | +0.02 +/- 1.36 | +1.02e-03 +/- 6.95e-02 | 5.12e+00 +/- 3.9e-02 | 5.12e+00 +/- 5.8e-02 |
test_proximal_freeb_compute | -4.66 +/- 3.60 | -7.60e-03 +/- 5.87e-03 | 1.56e-01 +/- 4.0e-03 | 1.63e-01 +/- 4.3e-03 |
test_solve_fixed_iter | -0.57 +/- 2.18 | -1.36e-01 +/- 5.17e-01 | 2.36e+01 +/- 4.3e-01 | 2.38e+01 +/- 2.8e-01 |
test_objective_compute_ripple | -2.02 +/- 4.53 | -4.60e-03 +/- 1.03e-02 | 2.24e-01 +/- 6.7e-03 | 2.28e-01 +/- 7.8e-03 |
test_objective_grad_ripple | -2.35 +/- 4.02 | -2.04e-02 +/- 3.48e-02 | 8.46e-01 +/- 2.0e-02 | 8.66e-01 +/- 2.9e-02 |
test_build_transform_fft_lowres | +3.69 +/- 13.55 | +2.01e-02 +/- 7.38e-02 | 5.65e-01 +/- 1.1e-02 | 5.45e-01 +/- 7.3e-02 |
test_equilibrium_init_medres | +3.52 +/- 3.04 | +1.58e-01 +/- 1.37e-01 | 4.65e+00 +/- 1.2e-01 | 4.50e+00 +/- 6.5e-02 |
test_equilibrium_init_highres | +2.52 +/- 3.08 | +1.29e-01 +/- 1.58e-01 | 5.26e+00 +/- 1.1e-01 | 5.13e+00 +/- 1.2e-01 |
test_objective_compile_dshape_current | -1.49 +/- 9.23 | -3.80e-02 +/- 2.36e-01 | 2.52e+00 +/- 2.3e-01 | 2.55e+00 +/- 3.2e-02 |
test_objective_compute_dshape_current | -1.49 +/- 6.89 | -8.56e-06 +/- 3.96e-05 | 5.66e-04 +/- 2.1e-05 | 5.74e-04 +/- 3.3e-05 |
test_objective_jac_dshape_current | -4.10 +/- 10.86 | -7.01e-04 +/- 1.85e-03 | 1.64e-02 +/- 9.8e-04 | 1.71e-02 +/- 1.6e-03 |
test_perturb_2 | +0.47 +/- 1.41 | +5.77e-02 +/- 1.74e-01 | 1.23e+01 +/- 1.2e-01 | 1.23e+01 +/- 1.2e-01 |
test_proximal_jac_atf_with_eq_update | -1.62 +/- 1.98 | -1.61e-01 +/- 1.97e-01 | 9.80e+00 +/- 1.1e-01 | 9.96e+00 +/- 1.7e-01 |
test_proximal_freeb_jac | +0.37 +/- 2.42 | +1.72e-02 +/- 1.13e-01 | 4.69e+00 +/- 1.0e-01 | 4.67e+00 +/- 5.1e-02 |
+test_solve_fixed_iter_compiled | -9.97 +/- 1.51 | -5.70e-01 +/- 8.61e-02 | 5.15e+00 +/- 7.4e-02 | 5.72e+00 +/- 4.4e-02 |
test_LinearConstraintProjection_build | +1.80 +/- 3.39 | +7.87e-02 +/- 1.48e-01 | 4.45e+00 +/- 1.1e-01 | 4.37e+00 +/- 9.6e-02 |
test_objective_compute_ripple_bounce1d | +0.37 +/- 11.96 | +7.19e-04 +/- 2.34e-02 | 1.96e-01 +/- 1.9e-02 | 1.96e-01 +/- 1.4e-02 |
test_objective_grad_ripple_bounce1d | +2.77 +/- 4.76 | +2.32e-02 +/- 3.98e-02 | 8.58e-01 +/- 3.4e-02 | 8.35e-01 +/- 2.1e-02 |Github CI performance can be noisy. When evaluating the benchmarks, developers should take this into account. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2235 +/- ##
=======================================
Coverage 94.32% 94.33%
=======================================
Files 101 101
Lines 28866 28873 +7
=======================================
+ Hits 27228 27236 +8
+ Misses 1638 1637 -1
🚀 New features to boost your workflow:
|
unalmis
left a comment
There was a problem hiding this comment.
Forced to block due to issue in above comment, and previous discussion.
| return z1[mask], z2[mask] | ||
|
|
||
| @pytest.mark.unit | ||
| @pytest.mark.xfail(reason="will be fixed by #2199") |
There was a problem hiding this comment.
It's the same problem as the above link, except this PR's approach is to break the code by releasing with a package that does not pass correctness tests.
There was a problem hiding this comment.
We discussed this in the dev meeting, and the decision was to add this flag temporarily. Small numerical differences in different versions of dependencies can already be causing problems that we haven't seen. For example, this workflow fails due to jax-finufft=1.2.0, currently this workflow is the only one that uses that version because test_compute_everything happens to run on the runner that uses Python=3.10. What I mean is we don't test each dependency Python version combination on CI, and if certain parts of the code are too sensitive to these, there's not much to do.
There won't be a release very soon. In the meantime, we can merge the proper fix #2199. I can approve that PR and we can merge it soon, but it would be a lot easier if you spent a couple of minutes to cherry-pick a couple of commits to point it to master. Otherwise, it will wait on a chain of PRs. I can say the same for couple other PRs too. You can keep the original PRs open, I am pretty sure if you merge the exact same changes to master, there won't be merge conflicts.
There was a problem hiding this comment.
I worked on DESC for 4 years. I will block PRs that 1) show failure in the correctness of the code, and 2) remove required testing infrastructure as means to silence such failures.
The other workflow things are non-sequitur.
Nothing is holding up the PRs you mentioned. My existing PRs that allow the code to work in a broader range of configurations have been ready for merge with no issues.
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
Updates the requirements on jax to permit the latest version.
Updates
jaxto 0.10.1Release notes
Sourced from jax's releases.
Changelog
Sourced from jax's changelog.
... (truncated)
Commits
619764cApply patch to revert XLA PR #42396 on release/0.10.1 branch433d98dPrepare for JAX release 0.10.18c38c32[Pallas] Enable disabled TPU Interpret Mode test of example kernel6820cf6[pallas:sc]pl.kernelis now the only API for writing Pallas SC kernels456b22d[state] Fixed a latent bug in_call_primitive_discharge_ruled154b80Update XLA dependency to use revision http://github.com/openxla/xla/commit/9b...11af068Update XLA dependency to use revision http://github.com/openxla/xla/commit/31...1ecdea1Improve compilation throughput in multi-threaded auto-tuning environments. Th...46f75a2Make JaxprEqnContext a bit easier to work with making it easier to add new co...7c01f9b[Pallas MPMD] Refactor tracing context