Skip to content

chore(deps): update mysql docker tag to v9.5 #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ijusti merged 3 commits into from
May 1, 2026
Merged

chore(deps): update mysql docker tag to v9.5 #2224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d43e1f
chore(deps): update mysql docker tag to v9.5
renovate-bot Nov 3, 2025
c759f77
Update MySQL version check in test
ijusti Nov 11, 2025
d7dcca4
test: update MySQL version assertion from 9.1 to 9.5
May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion embedded-mysql/README.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
* `embedded.mysql.reuseContainer` `(true|false, default is false)`
* `embedded.mysql.encoding` `(default is 'utf8mb4')`
* `embedded.mysql.collation` `(default is 'utf8mb4_unicode_ci')`
* `embedded.mysql.dockerImage` `(default is 'mysql:9.1')`
* `embedded.mysql.dockerImage` `(default is 'mysql:9.5')`
** Image versions on https://hub.docker.com/_/mysql?tab=tags[dockerhub]
* `embedded.mysql.waitTimeoutInSeconds` `(default is 60 seconds)`
* `embedded.mysql.initScriptPath` `(default is null)`
Expand Down
2 changes: 1 addition & 1 deletion embedded-mysql/src/main/java/com/playtika/testcontainer/mysql/MySQLProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ public class MySQLProperties extends CommonContainerProperties {
public String getDefaultDockerImage() {
// Please don`t remove this comment.
// renovate: datasource=docker
return "mysql:9.1";
return "mysql:9.5";
}
}
2 changes: 1 addition & 1 deletion ...src/test/java/com/playtika/testcontainer/mysql/AutoConfiguredDatasourceDependsOnTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public class AutoConfiguredDatasourceDependsOnTest {

@Test
public void shouldConnectToMySQL() {
assertThat(jdbcTemplate.queryForObject("select version()", String.class)).startsWith("9.1.");
assertThat(jdbcTemplate.queryForObject("select version()", String.class)).startsWith("9.5.");
}
Comment on lines 37 to 40
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Verify no tests still assert MySQL version "9.1."
rg -n "startsWith\\(\"9\\.1\\.\"\\)" embedded-mysql/src/test/java || true
rg -n "\"9\\.1\\.\"" embedded-mysql/src/test/java || true
rg -n "mysql:9\\.1" embedded-mysql/src || true

Repository: PlaytikaOSS/testcontainers-spring-boot

Length of output: 506

Update EmbeddedMySQLBootstrapConfigurationTest to assert MySQL 9.5 instead of 9.1.

Line 53 of EmbeddedMySQLBootstrapConfigurationTest.java still asserts startsWith("9.1.") while the default image version has been bumped to 9.5. This will cause the test to fail. Update the assertion to startsWith("9.5.") to match the new default version.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In
`@embedded-mysql/src/test/java/com/playtika/testcontainer/mysql/AutoConfiguredDatasourceDependsOnTest.java`
around lines 37 - 40, Update the failing version assertion in the bootstrap
test: in EmbeddedMySQLBootstrapConfigurationTest (the test method that calls
jdbcTemplate.queryForObject("select version()", String.class), e.g., the test
asserting startsWith("9.1.")), change the expected prefix from "9.1." to "9.5."
so it matches the new default image version; update the literal in that
assertion and re-run the test suite.


@Test
Expand Down
2 changes: 1 addition & 1 deletion ...c/test/java/com/playtika/testcontainer/mysql/EmbeddedMySQLBootstrapConfigurationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public class EmbeddedMySQLBootstrapConfigurationTest {

@Test
public void shouldConnectToMySQL() {
assertThat(jdbcTemplate.queryForObject("select version()", String.class)).startsWith("9.1.");
assertThat(jdbcTemplate.queryForObject("select version()", String.class)).startsWith("9.5.");
}

@Test
Expand Down
Loading