chore(deps): update confluentinc/cp-kafka docker tag to v8#2439
chore(deps): update confluentinc/cp-kafka docker tag to v8#2439
Conversation
2d08639 to
8c13ea1
Compare
e0ab74d to
5cd0b72
Compare
ee1c580 to
46661ea
Compare
07ac3f8 to
763e25e
Compare
10c46a0 to
f95848c
Compare
f95848c to
4b7de8d
Compare
4b7de8d to
5c2ae2e
Compare
5c2ae2e to
5cc0b63
Compare
5cc0b63 to
9c41cba
Compare
9c41cba to
6b508f8
Compare
6b508f8 to
5659bbc
Compare
ca309c4 to
a7caca6
Compare
a7caca6 to
fc3e63c
Compare
fc3e63c to
6f3ddf5
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughUpdated the default Confluent Kafka Docker image tag in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
6f3ddf5 to
18f4a75
Compare
2d6fc7a to
da38325
Compare
da38325 to
5a53079
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
embedded-kafka/src/main/java/com/playtika/testcontainer/kafka/properties/KafkaConfigurationProperties.java (1)
70-77:⚠️ Potential issue | 🔴 CriticalThis image upgrade requires migration to KRaft mode—ZooKeaker is no longer supported in cp-kafka 8.2.0.
The upgrade from cp-kafka 7.9.5 to 8.2.0 crosses a critical breaking change: Confluent Platform 8.0 removed ZooKeeper entirely and made KRaft mode mandatory. The current configuration in
KafkaContainerConfigurationstill useswithEmbeddedZookeeper()and ZooKeeper-oriented env variables (e.g.,KAFKA_ZOOKEEPER_CONNECT), which are no longer recognized or applicable in 8.x. The container will fail to start or behave unexpectedly with this image.To proceed safely, either:
- Revert to the fallback below and remain on cp-kafka 7.9.5:
Safe fallback
- return "confluentinc/cp-kafka:8.2.0"; + return "confluentinc/cp-kafka:7.9.5";
- Migrate
KafkaContainerConfigurationto KRaft mode (requires updating broker environment variables and removing ZooKeeper configuration).See Confluent's ZooKeeper to KRaft migration guide and 8.x Docker config reference for details.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@embedded-kafka/src/main/java/com/playtika/testcontainer/kafka/properties/KafkaConfigurationProperties.java` around lines 70 - 77, The Docker image was bumped to confluentinc/cp-kafka:8.2.0 but that image requires KRaft mode; either revert getDefaultDockerImage() in KafkaConfigurationProperties.getDefaultDockerImage() to the 7.9.5 tag or migrate KafkaContainerConfiguration to KRaft: remove calls to withEmbeddedZookeeper() and any use of KAFKA_ZOOKEEPER_CONNECT, drop ZooKeeper-specific env vars, and add KRaft-required broker envs (e.g., KAFKA_PROCESS_ROLES, KAFKA_NODE_ID, KAFKA_CONTROLLER_QUORUM_VOTERS, KAFKA_LISTENERS, KAFKA_CONTROLLER_LISTENER_NAMES) and any controller listener wiring so the container starts in KRaft mode compatible with the 8.x image.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In
`@embedded-kafka/src/main/java/com/playtika/testcontainer/kafka/properties/KafkaConfigurationProperties.java`:
- Around line 70-77: The Docker image was bumped to confluentinc/cp-kafka:8.2.0
but that image requires KRaft mode; either revert getDefaultDockerImage() in
KafkaConfigurationProperties.getDefaultDockerImage() to the 7.9.5 tag or migrate
KafkaContainerConfiguration to KRaft: remove calls to withEmbeddedZookeeper()
and any use of KAFKA_ZOOKEEPER_CONNECT, drop ZooKeeper-specific env vars, and
add KRaft-required broker envs (e.g., KAFKA_PROCESS_ROLES, KAFKA_NODE_ID,
KAFKA_CONTROLLER_QUORUM_VOTERS, KAFKA_LISTENERS,
KAFKA_CONTROLLER_LISTENER_NAMES) and any controller listener wiring so the
container starts in KRaft mode compatible with the 8.x image.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8c669a23-c307-4a0d-aeec-6d4a0e1ea629
📒 Files selected for processing (1)
embedded-kafka/src/main/java/com/playtika/testcontainer/kafka/properties/KafkaConfigurationProperties.java
5a53079 to
43202bd
Compare
43202bd to
0418fd5
Compare
| datasource | package | from | to | | ---------- | --------------------- | ----- | ----- | | docker | confluentinc/cp-kafka | 7.9.5 | 8.2.0 |
0418fd5 to
b0eeece
Compare
This PR contains the following updates:
7.9.2->8.0.0Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.
Summary by CodeRabbit