chore(deps): update confluentinc/cp-schema-registry docker tag to v8#2448
chore(deps): update confluentinc/cp-schema-registry docker tag to v8#2448
Conversation
ce71c2e to
a24249b
Compare
35e4824 to
b4566f1
Compare
6497eb3 to
68d171e
Compare
a2555fd to
9270215
Compare
9270215 to
52b3bb7
Compare
52b3bb7 to
5c0a0d8
Compare
5c0a0d8 to
d50aa4f
Compare
d50aa4f to
c6ba08e
Compare
c6ba08e to
a4bb307
Compare
a4bb307 to
9a70b46
Compare
8d78fb4 to
b8e90cb
Compare
b8e90cb to
107fda4
Compare
107fda4 to
ba457d5
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdated the default Confluent Schema Registry Docker image tag from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f68202f to
f97eab5
Compare
290a2ad to
31b1077
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@embedded-kafka/README.adoc`:
- Around line 23-24: The README incorrectly documents embedded.kafka.dockerImage
as pointing to the Schema Registry image; update the entry so
embedded.kafka.dockerImage references the correct Kafka broker image (e.g.,
confluentinc/cp-kafka with the intended version) and move the
confluentinc/cp-schema-registry:8.2.0 value (and version bump) to the
embedded.kafka.schema-registry.dockerImage entry so the schema-registry property
reflects 8.2.0 instead of the broker property.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5f946f4b-c994-42cb-88db-a77a3cec6f34
📒 Files selected for processing (2)
embedded-kafka/README.adocembedded-kafka/src/main/java/com/playtika/testcontainer/kafka/properties/SchemaRegistryConfigurationProperties.java
| * `embedded.kafka.dockerImage` `(default is set to 'confluentinc/cp-schema-registry:8.2.0')` | ||
| ** Image versions on https://hub.docker.com/r/confluentinc/cp-kafka/tags[dockerhub] |
There was a problem hiding this comment.
This documents the wrong property/image.
embedded.kafka.dockerImage is the broker image setting, but this line now points it at confluentinc/cp-schema-registry. Users copying it will configure the Kafka container with the Schema Registry image. The 8.2.0 update should be applied to embedded.kafka.schema-registry.dockerImage instead; that entry is still stale on Line 30.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@embedded-kafka/README.adoc` around lines 23 - 24, The README incorrectly
documents embedded.kafka.dockerImage as pointing to the Schema Registry image;
update the entry so embedded.kafka.dockerImage references the correct Kafka
broker image (e.g., confluentinc/cp-kafka with the intended version) and move
the confluentinc/cp-schema-registry:8.2.0 value (and version bump) to the
embedded.kafka.schema-registry.dockerImage entry so the schema-registry property
reflects 8.2.0 instead of the broker property.
31b1077 to
6ebb12b
Compare
| datasource | package | from | to | | ---------- | ------------------------------- | ----- | ----- | | docker | confluentinc/cp-schema-registry | 7.9.5 | 8.2.0 |
6ebb12b to
88358de
Compare
This PR contains the following updates:
7.9.2->8.0.0Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.
Summary by CodeRabbit