Skip to content

Commit 228ed68

Browse files
Alvvalenciaclaude
andcommitted
fix(ci): add gtest to the Anomaly Detector recipe (per-plugin build needs it)
The standalone root CMakeLists' find_package(GTest REQUIRED) runs for every per-plugin build, but toolbox_anomaly_detector/conanfile.py never listed gtest (every other plugin recipe does). The omission was masked because the Linux per-plugin leg died earlier resolving pj_scripting_core; with that spurious dependency gone (prev commit), Conan now succeeds and CMake configure failed on "Could NOT find GTest". Add gtest/1.17.0 to the recipe, matching the other plugins. Verified via the per-plugin path (./build.sh toolbox_anomaly_detector): GTest resolves, configure succeeds, the .so links. NOTE: this leg still fails to COMPILE against the published SDK (0.13.0) because anomaly_detector.cpp adopts the 5-arg setSaveFilePicker(default_suffix) contract, which lives in the not-yet-merged SDK default_suffix PR. That is the known, planned convergence dependency — it greens once the unified SDK PR merges and SDK_VERSION is bumped. This commit removes the gtest blocker so #138 is the single remaining one. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0122VUqQqWd1KVQQfhrG7632
1 parent 6876d16 commit 228ed68

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

toolbox_anomaly_detector/conanfile.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ class ToolboxAnomalyDetectorConan(ConanFile):
2121
requires = (
2222
f"plotjuggler_sdk/{_SDK_VERSION}",
2323
"nlohmann_json/3.12.0",
24+
# GTest backs the plugin's unit tests; the root CMakeLists' find_package(GTest)
25+
# runs for every per-plugin build, so each plugin's recipe must provide it.
26+
"gtest/1.17.0",
2427
)
2528
default_options = {
2629
"*:shared": False,

0 commit comments

Comments
 (0)