feat(parser_protobuf,parser_ros): classify + decode canonical video objects#125
Merged
Conversation
…bjects Recognize compressed-video schemas as kVideoFrame ObjectTopics so PlotJuggler 4 renders them as scene2D: - parser_protobuf: register a kVideoFrame handler for "PJ.VideoFrame" and "foxglove.CompressedVideo" (now wire-identical). parse_object decodes zero-copy via deserializeVideoFrameView (the data span aliases the payload, anchor forwarded); the slim scalar route (frame_id/format/data_size) uses the owning decode and honours use_embedded_timestamp_. - parser_ros: foxglove_msgs/CompressedVideo CDR handler -> sdk::VideoFrame (zero-copy uint8[] via deserializeByteSequence + payload anchor). - Tests for both protobuf schema names, the ROS CDR path, and anchor propagation. Requires a plotjuggler_core release carrying the Foxglove-aligned VideoFrame schema + deserializeVideoFrameView (data=3, format=4). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
… any_casts pj_emit_plugin_manifest sets CXX_VISIBILITY_PRESET=hidden on every plugin .so. On macOS that hides the concrete builtin structs' RTTI inside the dylib, so libc++ assigns sdk::VideoFrame a distinct type_info from the host/test executable's copy and std::any_cast<VideoFrame>(&record.object) returns null -- even though parseObject() returned the correct object. The protobuf VideoFrame object-route tests therefore failed only on macOS (Linux/libstdc++ compares type_info by name, so it is immune). parser_ros already carries this exact APPLE-only default-visibility override for the same reason; mirror it on parser_protobuf_plugin. The if(APPLE) guard keeps the hidden-visibility ELF isolation defaults on Linux untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
pabloinigoblasco
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Recognize compressed-video schemas as
kVideoFrameObjectTopics so PlotJuggler 4 renders them as scene2D.kVideoFramehandler forPJ.VideoFrameandfoxglove.CompressedVideo(now wire-identical).parse_objectdecodes zero-copy viadeserializeVideoFrameView(thedataspan aliases the payload, anchor forwarded). The slim scalar route (frame_id/format/data_size) uses the owning decode and honoursuse_embedded_timestamp_.foxglove_msgs/CompressedVideoCDR handler →sdk::VideoFrame(zero-copyuint8[]viadeserializeByteSequence+ payload anchor).Depends on
PlotJuggler/plotjuggler_sdk#111 (Foxglove-aligned
VideoFrameschema +deserializeVideoFrameView,data=3, format=4). CI will go green only after aplotjuggler_corerelease carrying that change (the Conan range resolves the published core). Merge order: core #111 → release → this PR.Test
./build.sh parser_protobuf && ./build.sh parser_ros; both test binaries green (built against a locallyconan created core #111).🤖 Generated with Claude Code