feat: Transform Editor toolbox plugin (custom & N→M derived series)#158
Merged
Conversation
pabloinigoblasco
force-pushed
the
feat/transform-editor
branch
from
a2da548 to
7aecb95
Compare
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
Contributor
Done — merged |
pabloinigoblasco
force-pushed
the
feat/transform-editor
branch
from
769dda8 to
a0b5b8d
Compare
Contributor
Author
|
I converted this into a draft because I found something I think it is wrong, double checking |
pabloinigoblasco
force-pushed
the
feat/transform-editor
branch
4 times, most recently
from
85a64e7 to
753941d
Compare
pabloinigoblasco
force-pushed
the
feat/transform-editor
branch
4 times, most recently
from
f743145 to
a47ce7e
Compare
Ports PlotJuggler 3's Custom Series / Function Editor as a data-only toolbox plugin. The UI mirrors PJ3: a Single Function tab (drag-drop source, additional sources with a primary-source radio in the first column, function body), a Batch Functions tab, and a function library — an interactive browser sub-panel and Import / Export of the library to a JSON file. Data-only: the plugin never runs a script itself. On Save it hands the host a self-describing Luau class (N inputs -> M outputs) via `pj.data_processors.v1`, run live as a DerivedEngine node; the live preview is produced host-side too (ephemeral transform + validate). There is no local Lua engine in the plugin. Requires plotjuggler_sdk 0.14.0 — the data-processor script API, the interactive sub-panel + table radio-column dialog additions (#136), and the save-file picker used by the library Export (#138). The extern/plotjuggler_core submodule is pinned to an SDK build carrying both. Contents: - transform_editor_plugin.cpp — dialog + toolbox: drag-drop, primary-source radio, function library browser, Import/Export, host-side preview, name-prompt + overwrite on Save, createTransform on Save. - transform_editor_dialog.ui — PJ3-style UI. - manifest.json / CMakeLists.txt / conanfile.py — registration; SDK 0.14.0. Pairs with the host side: PlotJuggler/PJ4#252.
pabloinigoblasco
force-pushed
the
feat/transform-editor
branch
from
a47ce7e to
e717b11
Compare
pabloinigoblasco
changed the title
Bring the Transform Editor plugin up to date: per-snippet language tagging in the library, Python module emission for the Python backend, and the validateScript(kind, language, script) update for the unified data_processors SDK.
Apply clang-format so pre-commit passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports PlotJuggler 3's Custom Series / Function Editor as a data-only toolbox plugin. The UI mirrors PJ3 — a Single Function tab (drag-drop source, a radio to pick which input is the primary
value, additional sources bound asv1..vN, function body), a Batch Functions tab, and a function library: an interactive browser sub-panel plus Import / Export of the library to a JSON file.The plugin is data-only: it never runs a script itself. On Save it hands the host a self-describing Luau class (N inputs -> M outputs) via
pj.data_processors.v1, run live as aDerivedEnginenode; the live preview is produced host-side too (ephemeral transform + validate). There is no local Lua engine in the plugin.Requirements
Requires plotjuggler_sdk 0.14.0 — the data-processor script API, the interactive sub-panel + table radio-column dialog additions (PlotJuggler/plotjuggler_sdk#136), and the save-file picker used by the library Export (PlotJuggler/plotjuggler_sdk#138). The
extern/plotjuggler_coresubmodule is pinned to an SDK build that carries both; it re-pins tomainonce those land.Contents
transform_editor_plugin.cpp— dialog + toolbox: drag-drop, primary-source radio, additional sources, function library browser, Import/Export, host-side preview, name-prompt + overwrite on Save,createTransformon Save.transform_editor_dialog.ui— PJ3-style UI.manifest.json/CMakeLists.txt/conanfile.py— registration; SDK 0.14.0.Pairs with
The PJ4 host side:
PlotJuggler/PJ4#252.