build: enable Windows ARM64 via local mpdecimal recipe override#73
Open
pabloinigoblasco wants to merge 1 commit intomainfrom
Open
build: enable Windows ARM64 via local mpdecimal recipe override#73pabloinigoblasco wants to merge 1 commit intomainfrom
pabloinigoblasco wants to merge 1 commit intomainfrom
Conversation
The Conan Center mpdecimal recipe rejects MSVC + non-x86 in validate(), blocking any plugin that transitively requires cpython (e.g. the reactive scripts toolbox) on windows-11-arm runners. mpdecimal's source already supports ARM64 via the portable C "ansi64" path (confirmed by upstream vcbuild_arm64.bat in mpdecimal 4.0.1) — only the Conan recipe gates it. This adds a local recipe override under conan_overrides/mpdecimal/ with two small diffs (allow armv8 in validate(), map "armv8" -> "ansi64" in the _build_msvc() machine dict), and a build.sh step that exports every override under conan_overrides/<pkg>/all/ before conan install so local revisions win resolution. Remove the override once Conan Center carries the fix upstream.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables Windows ARM64 (
windows-11-arm) builds for plugins that transitively depend oncpython(e.g.toolbox_reactive_scripts_editor).Problem
The Conan Center
mpdecimal/2.5.1recipe rejects MSVC + non-x86 architectures invalidate()and its_build_msvc()machine dict has noarmv8entry. Sincecpythonrequiresmpdecimaltransitively, every plugin embedding Python fails onwindows-11-armrunners with:Why this is fixable in the recipe alone
mpdecimal's source already supports ARM64 via the portable C
ansi64build path. mpdecimal 4.0.1 shipsvcbuild/vcbuild_arm64.batwhich setsMACHINE=ansi64aftervcvarsall x64_arm64and runs the existingMakefile.vcunmodified. The 2.5.1 source has the sameMakefile.vcstructure — only the Conan recipe gatesarmv8.Changes
conan_overrides/mpdecimal/all/— local copy of the upstream Conan Center recipe with two minimal diffs:validate(): allowarmv8for MSVC builds._build_msvc(): extend the machine dict with"armv8": "ansi64".build.sh— exports everyconan_overrides/<pkg>/all/recipe before runningconan install, so local revisions take precedence over Conan Center.conan_overrides/README.md— documents the override mechanism and the upstream tracking link.Verification
conan exportof the patched recipe succeeds locally.conan graph inforesolves cleanly forWindows + armv8(was previously rejected).conan graph infostill resolves forWindows + x86_64andWindows + x86(no regression).Test plan
ubuntu-22.04(x86_64) — should be unaffectedubuntu-22.04-arm(aarch64) — should be unaffectedmacos-15-intelandmacos-14— should be unaffectedwindows-latest(x64) — should be unaffectedwindows-11-arm(arm64) — the case this PR fixesFollow-up
Track the upstream Conan Center recipe; remove this override when armv8 support lands there. A contribution to
conan-io/conan-center-indexmirroring this diff would benefit the wider ecosystem.