add formatting consistent with plotjuggler App

Author: facontidavide

.clang-format

@@ -0,0 +1,66 @@
+---
+BasedOnStyle: Google
+AccessModifierOffset: -2
+ConstructorInitializerIndentWidth: 2
+AlignEscapedNewlinesLeft: false
+AlignTrailingComments: true
+AllowAllParametersOfDeclarationOnNextLine: false
+AllowShortIfStatementsOnASingleLine: false
+AllowShortLoopsOnASingleLine: false
+AllowShortFunctionsOnASingleLine: None
+AlwaysBreakTemplateDeclarations: true
+AlwaysBreakBeforeMultilineStrings: false
+BreakBeforeBinaryOperators: false
+BreakBeforeTernaryOperators: false
+BreakConstructorInitializers: BeforeComma
+BinPackParameters: true
+ColumnLimit: 100
+ConstructorInitializerAllOnOneLineOrOnePerLine: true
+DerivePointerBinding: false
+PointerBindsToType: true
+ExperimentalAutoDetectBinPacking: false
+IndentCaseLabels: true
+MaxEmptyLinesToKeep: 1
+NamespaceIndentation: None
+ObjCSpaceBeforeProtocolList: true
+PenaltyBreakBeforeFirstCallParameter: 19
+PenaltyBreakComment: 60
+PenaltyBreakString: 1
+PenaltyBreakFirstLessLess: 1000
+PenaltyExcessCharacter: 1000
+PenaltyReturnTypeOnItsOwnLine: 90
+SpacesBeforeTrailingComments: 2
+Cpp11BracedListStyle: false
+Standard: Auto
+IndentWidth: 2
+TabWidth: 2
+UseTab: Never
+IndentFunctionDeclarationAfterType: false
+SpacesInParentheses: false
+SpacesInAngles: false
+SpaceInEmptyParentheses: false
+SpacesInCStyleCastParentheses: false
+SpaceAfterControlStatementKeyword: true
+SpaceBeforeAssignmentOperators: true
+ContinuationIndentWidth: 4
+SortIncludes: false
+SpaceAfterCStyleCast: false
+BreakStringLiterals: false
+
+# Configure each individual brace in BraceWrapping
+BreakBeforeBraces: Custom
+
+# Control of individual brace wrapping cases
+BraceWrapping: {
+    AfterClass: 'true',
+    AfterControlStatement: 'true',
+    AfterEnum : 'true',
+    AfterFunction : 'true',
+    AfterNamespace : 'true',
+    AfterStruct : 'true',
+    AfterUnion : 'true',
+    BeforeCatch : 'true',
+    BeforeElse : 'true',
+    IndentBraces : 'false'
+}
+...

.pre-commit-config.yaml

@@ -0,0 +1,55 @@
+
+# To use:
+#
+#     pre-commit run -a
+#
+# Or:
+#
+#     pre-commit install  # (runs every time you commit in git)
+#
+# To update this file:
+#
+#     pre-commit autoupdate
+#
+# See https://github.com/pre-commit/pre-commit
+
+exclude: cmake/CPM.cmake|^3rdparty/|3rdparty
+repos:
+
+  # Standard hooks
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v4.5.0
+    hooks:
+      - id: check-added-large-files
+      - id: check-ast
+      - id: check-case-conflict
+      - id: check-docstring-first
+      - id: check-merge-conflict
+      - id: check-symlinks
+      - id: check-xml
+      - id: check-yaml
+      - id: debug-statements
+      - id: end-of-file-fixer
+        exclude_types: [svg]
+      - id: mixed-line-ending
+      - id: trailing-whitespace
+        exclude_types: [svg]
+      - id: fix-byte-order-marker
+
+  # CPP hooks
+  - repo: https://github.com/pre-commit/mirrors-clang-format
+    rev: v17.0.6
+    hooks:
+      - id: clang-format
+        args: ['-fallback-style=none', '-i']
+
+  # Spell check
+  # - repo: https://github.com/codespell-project/codespell
+  #   rev: v2.4.1
+  #   hooks:
+  #     - id: codespell
+  #       additional_dependencies:
+  #       -   tomli
+  #       args:
+  #           [--toml=./tools/pyproject.toml]
+  #       exclude_types: [svg]

.vscode/settings.json

@@ -0,0 +1,3 @@
+{
+    "ros.distro": "humble"
+}

CMakeLists.txt

@@ -73,9 +73,7 @@ set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin)
 
 install(DIRECTORY launch
 	DESTINATION share/${PROJECT_NAME})
-    
+
 add_subdirectory( src )
 
 ament_package()
-
-

README.md

@@ -33,7 +33,7 @@ Create a catkin workspace and clone the repositories:
      git clone https://github.com/PlotJuggler/plotjuggler_msgs.git
      git clone https://github.com/facontidavide/PlotJuggler.git
      git clone https://github.com/PlotJuggler/plotjuggler-ros-plugins.git
-     
+
 Now, it is time to compile:
 
     cd ~/ws_plotjuggler
@@ -43,6 +43,3 @@ Now, it is time to compile:
 # For ROS (1) users
 
 From version 2.3+, this library will support only ROS2 (Hubmle or older)
-
-    
-     

launch/plotjuggler.launch

@@ -1,4 +1,3 @@
 <launch>
     <node name = "PlotJuggler" pkg = "plotjuggler" type = "plotjuggler" output = "screen" />
 </launch>
-

src/CMakeLists.txt

@@ -9,7 +9,7 @@ QT5_WRAP_UI ( COMMON_UI_SRC
     publisher_select_dialog.ui )
 
 
-add_library( commonROS STATIC 
+add_library( commonROS STATIC
    dialog_select_ros_topics.h
     dialog_select_ros_topics.cpp
     dialog_with_itemlist.h
@@ -60,6 +60,5 @@ install(TARGETS
         DataLoadROS2
         DataStreamROS2
         TopicPublisherROS2
-        DESTINATION  lib/${PROJECT_NAME}  
+        DESTINATION  lib/${PROJECT_NAME}
     )
-

src/DataLoadROS2/dataload_ros2.cpp

@@ -40,8 +40,7 @@ const std::vector<const char*>& DataLoadROS2::compatibleFileExtensions() const
   return _extensions;
 }
 
-bool DataLoadROS2::readDataFromFile(PJ::FileLoadInfo* info,
-                                    PJ::PlotDataMapRef& plot_map)
+bool DataLoadROS2::readDataFromFile(PJ::FileLoadInfo* info, PJ::PlotDataMapRef& plot_map)
 {
   auto metadata_io = std::make_unique<rosbag2_storage::MetadataIo>();
 
@@ -71,14 +70,17 @@ bool DataLoadROS2::readDataFromFile(PJ::FileLoadInfo* info,
   }
   catch (std::runtime_error& ex)
   {
-    QMessageBox::warning(nullptr, tr("Error"), QString("rosbag::open thrown an exception:\n") + QString(ex.what()));
+    QMessageBox::warning(nullptr, tr("Error"),
+                         QString("rosbag::open thrown an exception:\n") + QString(ex.what()));
     return false;
   }
 
   QDir::setCurrent(oldPath);
 
-  // Temporarily change the current directory as a workaround for rosbag2 relative directories not working properly
-  std::vector<rosbag2_storage::TopicMetadata> topic_metadata = temp_bag_reader->get_all_topics_and_types();
+  // Temporarily change the current directory as a workaround for rosbag2 relative directories not
+  // working properly
+  std::vector<rosbag2_storage::TopicMetadata> topic_metadata =
+      temp_bag_reader->get_all_topics_and_types();
 
   std::unordered_map<std::string, std::string> topicTypesByName;
 
@@ -91,25 +93,27 @@ bool DataLoadROS2::readDataFromFile(PJ::FileLoadInfo* info,
 
   for (const rosbag2_storage::TopicMetadata& topic : topic_metadata)
   {
-    all_topics_qt.push_back( {QString::fromStdString(topic.name),
-                              QString::fromStdString(topic.type)} );
+    all_topics_qt.push_back(
+        { QString::fromStdString(topic.name), QString::fromStdString(topic.type) });
     topicTypesByName.emplace(topic.name, topic.type);
 
     const auto& typesupport_identifier = rosidl_typesupport_cpp::typesupport_identifier;
     try
     {
-      topics_info.emplace_back( CreateTopicInfo(topic.name, topic.type) );
-
-    } catch (...) {
+      topics_info.emplace_back(CreateTopicInfo(topic.name, topic.type));
+    }
+    catch (...)
+    {
       failed_topic_type.insert(topic.type);
       blacklist_topic_name.insert(topic.type);
     }
   }
 
-  if(!failed_topic_type.empty())
+  if (!failed_topic_type.empty())
   {
-    QString msg("Can not recognize the following message types and those topics will be ignored:\n\n");
-    for(const auto& type: failed_topic_type)
+    QString msg(
+        "Can not recognize the following message types and those topics will be ignored:\n\n");
+    for (const auto& type : failed_topic_type)
     {
       msg += "  " + QString::fromStdString(type) + "\n";
     }
@@ -159,10 +163,8 @@ bool DataLoadROS2::readDataFromFile(PJ::FileLoadInfo* info,
     std::string topic_type = topicTypesByName.at(topic_name);
     topic_selected.insert(topic_name);
 
-    auto ros2_parser = CreateParserROS2( *parserFactories(), 
-                                         topic_name, topic_type, plot_map);
+    auto ros2_parser = CreateParserROS2(*parserFactories(), topic_name, topic_type, plot_map);
     parser.addParser(topic_name, ros2_parser);
-
   }
 
   parser.setConfig(_config);
@@ -181,15 +183,15 @@ bool DataLoadROS2::readDataFromFile(PJ::FileLoadInfo* info,
       plot_map.addUserDefined("plotjuggler::rosbag2_cpp::topics_metadata")->second;
 
   // dirty trick. Store it in a one point timeseries
-  metadata_storage.pushBack( {0, std::any(topics_info) } );
+  metadata_storage.pushBack({ 0, std::any(topics_info) });
 
   auto time_prev = std::chrono::high_resolution_clock::now();
 
   while (_bag_reader->has_next())
   {
     auto msg = _bag_reader->read_next();
     const std::string& topic_name = msg->topic_name;
-    if(blacklist_topic_name.count(topic_name))
+    if (blacklist_topic_name.count(topic_name))
     {
       continue;
     }