Commit 75c97d4
committed
fix: detect Humble via rclcpp_VERSION instead of ROS_DISTRO env var
Commit 63e6e28 added a ROS_HUMBLE compile flag guarded by
`if("$ENV{ROS_DISTRO}" STREQUAL "humble")`, but in the GitHub Actions
build farm that check did not match even though ROS_DISTRO was "humble"
at configure time. As a result the Humble build compiled the Jazzy+
branch and failed with:
'get_message_typesupport_handle' is not a member of 'rclcpp';
did you mean 'get_typesupport_handle'?
Switch the detection to the rclcpp_VERSION variable populated by
find_package(rclcpp). Humble ships rclcpp 16.x (threshold <17); Jazzy
and newer ship 28.x+. This is deterministic and independent of the
invoking shell's environment.1 parent 63e6e28 commit 75c97d4
1 file changed
Lines changed: 4 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
53 | 52 | | |
54 | 53 | | |
55 | 54 | | |
| |||
0 commit comments