Skip to content

Commit 82b9d41

Browse files
committed
use rclcpp type support helpers instead of rosbag2_cpp ones
Signed-off-by: Dominik Authaler <dominik.authaler@uni-ulm.de>
1 parent e88cef2 commit 82b9d41

4 files changed

Lines changed: 15 additions & 15 deletions

File tree

src/DataLoadROS2/dataload_ros2.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
#include <rosidl_typesupport_introspection_cpp/message_introspection.hpp>
1818
#include <rosidl_typesupport_introspection_cpp/field_types.hpp>
1919
#include <rosidl_typesupport_cpp/identifier.hpp>
20-
#include <rosbag2_cpp/typesupport_helpers.hpp>
2120
#include <rosbag2_cpp/types/introspection_message.hpp>
2221
#include <unordered_map>
2322
#include <rclcpp/rclcpp.hpp>

src/TopicPublisherROS2/generic_publisher.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,9 @@ class GenericPublisher : public rclcpp::PublisherBase
4848
static std::shared_ptr<GenericPublisher> create(rclcpp::Node& node, const std::string& topic_name,
4949
const std::string& topic_type)
5050
{
51-
auto library = std::move(rosbag2_cpp::get_typesupport_library(topic_type, "rosidl_typesupport_cpp"));
52-
auto type_support = rosbag2_cpp::get_typesupport_handle(topic_type, "rosidl_typesupport_cpp", library);
51+
52+
auto library = std::move(rclcpp::get_typesupport_library(topic_type, "rosidl_typesupport_cpp"));
53+
auto type_support = rclcpp::get_typesupport_handle(topic_type, "rosidl_typesupport_cpp", *library);
5354

5455
return std::make_shared<GenericPublisher>(node.get_node_base_interface().get(), topic_name, *type_support);
5556
}

src/ros_parsers/ros2_parser.cpp

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,11 @@ std::string CreateSchema(const std::string& base_type)
4141
std::set<std::string> secondary_types_pending;
4242
std::set<std::string> secondary_types_done;
4343

44-
auto addTypeToSchema = [&](const std::string& type_name, bool add_header) {
45-
auto introspection_library =
46-
rosbag2_cpp::get_typesupport_library(type_name, "rosidl_typesupport_introspection_cpp");
47-
auto introspection_support =
48-
rosbag2_cpp::get_typesupport_handle(type_name, "rosidl_typesupport_introspection_cpp", introspection_library);
44+
auto addTypeToSchema = [&](const std::string& type_name, bool add_header)
45+
{
46+
auto introspection_library = rclcpp::get_typesupport_library(type_name, "rosidl_typesupport_introspection_cpp");
47+
auto introspection_support = rclcpp::get_typesupport_handle(type_name, "rosidl_typesupport_introspection_cpp",
48+
*introspection_library);
4949

5050
if (add_header)
5151
{
@@ -147,13 +147,13 @@ TopicInfo CreateTopicInfo(const std::string& topic_name, const std::string& type
147147
info.topic_name = topic_name;
148148
info.type = type_name;
149149

150-
info.introspection_library = rosbag2_cpp::get_typesupport_library(type_name, "rosidl_typesupport_introspection_cpp");
151-
info.introspection_support = rosbag2_cpp::get_typesupport_handle(type_name, "rosidl_typesupport_introspection_cpp",
152-
info.introspection_library);
150+
info.introspection_library = rclcpp::get_typesupport_library(type_name, "rosidl_typesupport_introspection_cpp");
151+
info.introspection_support = rclcpp::get_typesupport_handle(type_name, "rosidl_typesupport_introspection_cpp",
152+
*info.introspection_library);
153153

154-
auto identifier = rosidl_typesupport_cpp::typesupport_identifier;
155-
info.support_library = rosbag2_cpp::get_typesupport_library(type_name, identifier);
156-
info.type_support = rosbag2_cpp::get_typesupport_handle(type_name, identifier, info.support_library);
154+
auto identifier = rosidl_typesupport_cpp::typesupport_identifier;
155+
info.support_library = rclcpp::get_typesupport_library(type_name, identifier);
156+
info.type_support = rclcpp::get_typesupport_handle(type_name, identifier, *info.support_library);
157157

158158
info.has_header_stamp = TypeHasHeader(info.introspection_support);
159159
return info;

src/ros_parsers/ros2_parser.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
#include "rclcpp/rclcpp.hpp"
44
#include "rmw/rmw.h"
55
#include "rmw/types.h"
6-
#include "rosbag2_cpp/typesupport_helpers.hpp"
6+
#include "rclcpp/typesupport_helpers.hpp"
77
#include "rosidl_typesupport_introspection_cpp/message_introspection.hpp"
88

99
#include <PlotJuggler/plotdata.h>

0 commit comments

Comments
 (0)